Re: [PATCH 1/4 v2] perf: Allow ability to map cpus to nodes easily

[Jiri Olsa <jolsa@redhat.com>]

On Mon, Apr 07, 2014 at 02:55:21PM -0400, Don Zickus wrote:

SNIP

> +static int init_cpunode_map(void)
> +{
> +	int i;
> +
> +	set_max_cpu_num();
> +	set_max_node_num();
> +
> +	cpunode_map = calloc(max_cpu_num, sizeof(int));
> +	if (!cpunode_map) {
> +		pr_err("%s: calloc failed\n", __func__);
> +		goto out;
shuld probably be ^^^:

		return -1;

> +	}
> +
> +	for (i = 0; i < max_cpu_num; i++)
> +		cpunode_map[i] = -1;
> +
> +	return 0;
> +out:
> +	return -1;

and remove 'out' label code

other than that, it seems ok.. I'll queue it

thanks,
jirka