From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbaDNCyN (ORCPT ); Sun, 13 Apr 2014 22:54:13 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:49450 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbaDNCyM (ORCPT ); Sun, 13 Apr 2014 22:54:12 -0400 Date: Sun, 13 Apr 2014 22:54:07 -0400 (EDT) Message-Id: <20140413.225407.1762639913754561393.davem@davemloft.net> To: xiaoming.wang@intel.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mguzik@redhat.com, chuansheng.liu@intel.com, dongxing.zhang@intel.com Subject: Re: [PATCH] net: ipv4: current group_info should be put after using. From: David Miller In-Reply-To: <1397493045.2575.8.camel@wxm-ubuntu> References: <1397493045.2575.8.camel@wxm-ubuntu> X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sun, 13 Apr 2014 19:54:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Wang, Xiaoming" Date: Mon, 14 Apr 2014 12:30:45 -0400 > Plug a group_info refcount leak in ping_init. > group_info is only needed during initialization and > the code failed to release the reference on exit. > While here move grabbing the reference to a place > where it is actually needed. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Zhang Dongxing > Signed-off-by: xiaoming wang Applied and queued up for -stable, thanks.