From: David Miller <davem@davemloft.net>
To: zhen-hual@hp.com
Cc: kas@fi.muni.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] driver/net: remove unused code in cosa module
Date: Mon, 14 Apr 2014 13:31:00 -0400 (EDT) [thread overview]
Message-ID: <20140414.133100.2108506432746999980.davem@davemloft.net> (raw)
In-Reply-To: <1397470116-19669-1-git-send-email-zhen-hual@hp.com>
From: "Li, Zhen-Hua" <zhen-hual@hp.com>
Date: Mon, 14 Apr 2014 18:08:36 +0800
> For the cosa module, CONFIG_COSA can only be checked as 'm',
> and cosa module can only be compiled as a module.
That's not true, it's "tristate" in drivers/net/wan/Kconfig so it
could be set to 'y' too.
But there is another reason to make this change, because for such
large timeout values only msleep() makes sense, udelay() could
overflow it's internal precision.
Please resubmit this with the proper reasoning and commit message.
next prev parent reply other threads:[~2014-04-14 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 10:08 Li, Zhen-Hua
2014-04-14 17:31 ` David Miller [this message]
2014-04-15 1:44 ` Li, ZhenHua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414.133100.2108506432746999980.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhen-hual@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®