mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: nasa4836@gmail.com, jchapman@katalix.com, edumazet@google.com,
	joe@perches.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [BUG] A panic caused by null pointer dereference aftering updating to
Date: Mon, 14 Apr 2014 18:51:52 -0400 (EDT)	[thread overview]
Message-ID: <20140414.185152.204599887297456936.davem@davemloft.net> (raw)
In-Reply-To: <1397510604.4222.63.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Apr 2014 14:23:24 -0700

> I was trying to cook a not too invasive patch.
> 
> Changing ip_local_out() means changing dst_output() / nf_hook()  and
> hundred of call sites.
> 
> Unless I misunderstood you ?

You could make ip_local_out(skb) be __ip_local_out(skb, skb->sk) and
make tunnel output use __ip_local_out().

  reply	other threads:[~2014-04-14 22:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAHz2CGWs-JH0v3dWAMBDrKqkP6ygb48YZ-qkc=KsFqz5yO7f+Q@mail.gmail.com>
     [not found] ` <CAHz2CGU5aPA5QJ9ED9g5kahD_jJaeLF+VOotUSBFXDkY+EH8ow@mail.gmail.com>
2014-04-14 15:19   ` James Chapman
2014-04-14 17:01     ` Zhan Jianyu
2014-04-14 17:12       ` Eric Dumazet
2014-04-14 17:34         ` David Miller
2014-04-14 17:40           ` Eric Dumazet
2014-04-14 17:49             ` David Miller
2014-04-14 17:54               ` Eric Dumazet
2014-04-14 18:02                 ` David Miller
2014-04-14 18:19                   ` Eric Dumazet
2014-04-14 18:48                     ` David Miller
2014-04-14 19:06                       ` Eric Dumazet
2014-04-14 19:22                         ` David Miller
2014-04-14 21:23                           ` Eric Dumazet
2014-04-14 22:51                             ` David Miller [this message]
2014-04-15  0:14                               ` Eric Dumazet
2014-04-15  6:32                                 ` Zhan Jianyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140414.185152.204599887297456936.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jchapman@katalix.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nasa4836@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®