From: Mark Brown <broonie@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Sebastian Reichel" <sre@ring0.de>,
"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Tony Lindgren" <tony@atomide.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jarkko Nikula" <jarkko.nikula@bitmer.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH 1/5] ASoC: omap: rx51: Use devm_snd_soc_register_card
Date: Tue, 15 Apr 2014 13:20:44 +0100 [thread overview]
Message-ID: <20140415122044.GZ12304@sirena.org.uk> (raw)
In-Reply-To: <1396733753-9820-2-git-send-email-sre@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Sat, Apr 05, 2014 at 11:35:49PM +0200, Sebastian Reichel wrote:
> From: Pali Rohár <pali.rohar@gmail.com>
>
> This patch converts the rx51 ASoC module to use
> devm_snd_soc_register_card. It also adds module alias
> to support driver autoloading.
This doesn't apply against current code and since it does multiple
things it should be multiple patches.
> +static int rx51_soc_remove(struct platform_device *pdev)
> {
> + struct snd_soc_card *card = platform_get_drvdata(pdev);
> +
> snd_soc_jack_free_gpios(&rx51_av_jack, ARRAY_SIZE(rx51_av_jack_gpios),
> rx51_av_jack_gpios);
>
> - platform_device_unregister(rx51_snd_device);
> + card->dev = NULL;
> +
Why is this assignment being done?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-15 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 21:35 [PATCH 0/5] DT support for N900 soundcard (rx51-audio) Sebastian Reichel
2014-04-05 21:35 ` [PATCH 1/5] ASoC: omap: rx51: Use devm_snd_soc_register_card Sebastian Reichel
2014-04-15 12:20 ` Mark Brown [this message]
2014-04-15 13:39 ` [alsa-devel] " Rajeev kumar
2014-04-05 21:35 ` [PATCH 2/5] ASoC: Allow Aux Codecs to be specified using DT Sebastian Reichel
2014-04-15 12:14 ` Mark Brown
2014-04-05 21:35 ` [PATCH 3/5] ASoC: RX-51: Add DT support to sound driver Sebastian Reichel
2014-04-15 12:34 ` Mark Brown
2014-04-05 21:35 ` [PATCH 4/5] ASoC: RX-51: Convert to table based DAPM setup Sebastian Reichel
2014-04-15 12:23 ` Mark Brown
2014-04-05 21:35 ` [PATCH 5/5] ASoC: tlv320aic3x: fix shared reset pin for DT Sebastian Reichel
2014-04-15 12:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415122044.GZ12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=pawel.moll@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sre@kernel.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®