From: Pavel Machek <pavel@ucw.cz>
To: Rabin Vincent <rabin@rab.in>
Cc: balbi@ti.com, Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
pali.rohar@gmail.com, linux-usb@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: Fix obex in g_nokia.ko causing kernel panic
Date: Tue, 15 Apr 2014 23:37:24 +0200 [thread overview]
Message-ID: <20140415213724.GA819@amd.pavel.ucw.cz> (raw)
In-Reply-To: <CAH+eYFAnc+k+3kSH4_YDRG-zX_ioBwZ_jGdpyvUWFqf_=6kYGA@mail.gmail.com>
Hi!
> > From: Felipe Balbi <balbi@ti.com>
>
> This patch, which is present in 3.14-rc4 as 30a70b026 ("usb: musb: fix
> obex in g_nokia.ko causing kernel panic"), breaks USB gadget support
> on my Pandaboard. Bisecting points to this commit, reverting it makes
> USB gadget support work again. The problem is that this patch deletes
> the call which turns on the PHY.
>
> Config is attached.
Can you try adding
static int omap2430_musb_init(struct musb *musb)
{
...
+ phy_power_on(musb->phy);
return 0;
...
}
?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2014-04-15 21:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 10:51 BUG: usb: " Pali Rohár
2013-11-26 17:10 ` Pali Rohár
2013-11-26 17:17 ` Sebastian Reichel
2013-11-26 17:30 ` Pali Rohár
2013-11-26 18:06 ` Pavel Machek
2013-11-26 18:10 ` Felipe Balbi
2013-11-26 17:16 ` Felipe Balbi
2013-11-26 17:28 ` Pali Rohár
2013-11-26 17:39 ` Felipe Balbi
2013-11-26 18:10 ` Pali Rohár
2013-11-26 18:59 ` Felipe Balbi
2013-11-26 19:03 ` Felipe Balbi
2013-11-27 16:40 ` Pali Rohár
2013-11-27 17:39 ` Felipe Balbi
2014-01-09 14:17 ` Pali Rohár
2014-01-26 22:06 ` Pali Rohár
2014-02-05 22:25 ` Ivaylo Dimitrov
2014-02-05 23:06 ` Greg Kroah-Hartman
2014-02-06 19:25 ` [PATCH] usb: musb: Fix " Ivaylo Dimitrov
2014-02-06 19:33 ` Greg KH
2014-03-22 0:45 ` Rabin Vincent
2014-04-15 21:37 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415213724.GA819@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®