From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Fabio Estevam <festevam@gmail.com>
Cc: sameo@linux.intel.com, lee.jones@linaro.org,
linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] mfd: mc13xxx-core: Initialize the lock prior to using it
Date: Tue, 15 Apr 2014 23:52:51 +0100 [thread overview]
Message-ID: <20140415225250.GB24070@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1397601790-27916-1-git-send-email-festevam@gmail.com>
On Tue, Apr 15, 2014 at 07:43:10PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> After request_threaded_irq() is called there is a chance that an interrupt
> may occur before the 'mc13xxx->lock' is initialized, which will trigger a kernel
> warning.
I'd suggest... "which will trigger a kernel oops" because that's what
you got - it killed the IRQ thread, which then caused a few other
problems along the way.
> In order to prevent that, move the initialization of 'mc13xxx->lock' prior to
> requesting the interrupts.
>
> Suggested-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Patch looks good, and should fix the reported issue... so with the above
description fixed,
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Thanks.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
prev parent reply other threads:[~2014-04-15 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 22:43 Fabio Estevam
2014-04-15 22:52 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415225250.GB24070@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®