From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: stable@vger.kernel.org
Subject: [patch 3/4] clocksource: exynos_mct: Use irq_force_affinity() in cpu bringup
Date: Wed, 16 Apr 2014 14:36:45 -0000 [thread overview]
Message-ID: <20140416143316.106665251@linutronix.de> (raw)
In-Reply-To: <20140416142106.537575971@linutronix.de>
[-- Attachment #1: clocksource-exynos_mct-use-irq-force-affinity.patch --]
[-- Type: text/plain, Size: 1496 bytes --]
The starting cpu is not yet in the online mask so irq_set_affinity()
fails which results in per cpu timers for this cpu ending up on some
other online cpu, ususally cpu 0.
Use irq_force_affinity() which disables the online mask check and
makes things work.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/clocksource/exynos_mct.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
Index: tip/drivers/clocksource/exynos_mct.c
===================================================================
--- tip.orig/drivers/clocksource/exynos_mct.c
+++ tip/drivers/clocksource/exynos_mct.c
@@ -430,6 +430,7 @@ static int exynos4_local_timer_setup(str
evt->irq);
return -EIO;
}
+ irq_force_affinity(mct_irqs[MCT_L0_IRQ + cpu], cpumask_of(cpu));
} else {
enable_percpu_irq(mct_irqs[MCT_L0_IRQ], 0);
}
@@ -450,7 +451,6 @@ static int exynos4_mct_cpu_notify(struct
unsigned long action, void *hcpu)
{
struct mct_clock_event_device *mevt;
- unsigned int cpu;
/*
* Grab cpu pointer in each case to avoid spurious
@@ -461,12 +461,6 @@ static int exynos4_mct_cpu_notify(struct
mevt = this_cpu_ptr(&percpu_mct_tick);
exynos4_local_timer_setup(&mevt->evt);
break;
- case CPU_ONLINE:
- cpu = (unsigned long)hcpu;
- if (mct_int_type == MCT_INT_SPI)
- irq_set_affinity(mct_irqs[MCT_L0_IRQ + cpu],
- cpumask_of(cpu));
- break;
case CPU_DYING:
mevt = this_cpu_ptr(&percpu_mct_tick);
exynos4_local_timer_stop(&mevt->evt);
next prev parent reply other threads:[~2014-04-16 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:36 [patch 0/4] genirq/exynos timers: Fix the CPU hotplug wreckage sanely Thomas Gleixner
2014-04-16 14:36 ` [patch 1/4] genirq: Allow forcing cpu affinity of interrupts Thomas Gleixner
2014-04-17 21:39 ` [tip:irq/urgent] " tip-bot for Thomas Gleixner
2014-04-16 14:36 ` [patch 2/4] irqchip: gic: Support forced affinity setting Thomas Gleixner
2014-04-17 21:39 ` [tip:irq/urgent] irqchip: Gic: " tip-bot for Thomas Gleixner
2014-04-16 14:36 ` Thomas Gleixner [this message]
2014-04-17 21:40 ` [tip:irq/urgent] clocksource: Exynos_mct: Use irq_force_affinity( ) in cpu bringup tip-bot for Thomas Gleixner
2014-04-16 14:36 ` [patch 4/4] clocksource: exynos_mct: Register clock event after request_irq() Thomas Gleixner
2014-04-17 21:40 ` [tip:irq/urgent] clocksource: Exynos_mct: " tip-bot for Krzysztof Kozlowski
2014-04-16 15:59 ` [patch 0/4] genirq/exynos timers: Fix the CPU hotplug wreckage sanely Krzysztof Kozlowski
2014-04-16 21:16 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416143316.106665251@linutronix.de \
--to=tglx@linutronix.de \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®