mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: gregkh@linuxfoundation.org, lizefan@huawei.com,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] kernfs: move the last knowledge of sysfs out from kernfs
Date: Wed, 16 Apr 2014 12:46:07 -0400	[thread overview]
Message-ID: <20140416164607.GJ1257@htj.dyndns.org> (raw)
In-Reply-To: <1397666401-10427-1-git-send-email-nasa4836@gmail.com>

Hello,

On Thu, Apr 17, 2014 at 12:40:01AM +0800, Jianyu Zhan wrote:
> @@ -132,6 +132,7 @@ const void *kernfs_super_ns(struct super_block *sb)
>   * @flags: mount flags specified for the mount
>   * @root: kernfs_root of the hierarchy being mounted
>   * @new_sb_created: tell the caller if we allocated a new superblock
> + * @private: any file system specifc private data

Please put it before @new_sb_created.  Also, why isn't it unsigned
long magic?

Thanks.

-- 
tejun

  reply	other threads:[~2014-04-16 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 16:40 Jianyu Zhan
2014-04-16 16:46 ` Tejun Heo [this message]
2014-04-16 17:24 Jianyu Zhan
2014-04-16 17:26 ` Tejun Heo
2014-04-25 19:39 ` Greg KH
2014-04-26  7:40 Jianyu Zhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140416164607.GJ1257@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=nasa4836@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®