mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: laijs@cn.fujitsu.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path
Date: Wed, 16 Apr 2014 13:30:22 -0400	[thread overview]
Message-ID: <20140416173022.GN1257@htj.dyndns.org> (raw)
In-Reply-To: <58237829.Dxp0IlFuXc@daeseok-laptop.cloud.net>

On Wed, Apr 16, 2014 at 02:32:29PM +0900, Daeseok Youn wrote:
> 
> wq_update_unbound_numa() failure path has the following two bugs.
>  - alloc_unbound_pwq() is called without holding wq->mutex;
>  however, if the allocation fails, it jumps to out_unlock
>  which tries to unlock wq->mutex.
> 
>  - The function should switch to dfl_pwq on failure
>  but didn't do so after alloc_unbound_pwq() failure.
> 
> Fix it by regrabbing wq->mutex and jumping to use_dfl_pwq on
> alloc_unbound_pwq() failure.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>

Applied to wq/for-3.15-fixes.

Thanks.

-- 
tejun

  parent reply	other threads:[~2014-04-16 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16  5:32 Daeseok Youn
2014-04-16 16:22 ` Lai Jiangshan
2014-04-16 17:30 ` Tejun Heo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-04-16  5:22 Daeseok Youn
2014-04-16  5:11 Daeseok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140416173022.GN1257@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=daeseok.youn@gmail.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®