mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] ahci: Ensure "MSI Revert to Single Message" mode is not enforced
Date: Wed, 16 Apr 2014 16:01:32 -0400	[thread overview]
Message-ID: <20140416200132.GG22569@htj.dyndns.org> (raw)
In-Reply-To: <fe4097ff2b486092108663532c015a40984bc5f9.1396426390.git.agordeev@redhat.com>

Hello, Alexander.

On Wed, Apr 02, 2014 at 10:19:56AM +0200, Alexander Gordeev wrote:
> +static int ahci_is_mrsm(struct ahci_host_priv *hpriv)
> +{
> +	void __iomem *mmio = hpriv->mmio;
> +	u32 ctl = readl(mmio + HOST_CTL);
> +
> +	return ctl & HOST_MRSM;
> +}

Can you please just open code this in ahci_init_interrupt()?  Also, do
I need to backport this through -stable?  Has this been tested
somehow?  What are the impacts of missing this?

Thanks.

-- 
tejun

  reply	other threads:[~2014-04-16 20:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02  8:19 [PATCH 0/2] ahci: Tweaks to the driver's PCI function Alexander Gordeev
2014-04-02  8:19 ` [PATCH 1/2] ahci: Ensure "MSI Revert to Single Message" mode is not enforced Alexander Gordeev
2014-04-16 20:01   ` Tejun Heo [this message]
2014-04-17 12:16     ` Alexander Gordeev
2014-04-02  8:19 ` [PATCH 2/2] ahci: Use pci_enable_msi_exact() instead of pci_enable_msi_range() Alexander Gordeev
2014-04-16 20:02   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140416200132.GG22569@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=agordeev@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®