From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756732AbaDPUuB (ORCPT ); Wed, 16 Apr 2014 16:50:01 -0400 Received: from mail-qa0-f54.google.com ([209.85.216.54]:57009 "EHLO mail-qa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754986AbaDPUt7 (ORCPT ); Wed, 16 Apr 2014 16:49:59 -0400 Date: Wed, 16 Apr 2014 16:49:55 -0400 From: Tejun Heo To: Kefeng Wang Cc: Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, guohanjun@huawei.com, Kefeng Wang , Haojian Zhuang Subject: Re: [PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS Message-ID: <20140416204955.GC26632@htj.dyndns.org> References: <1397107468-640-1-git-send-email-wangkefeng.wang@huawei.com> <1397107468-640-2-git-send-email-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1397107468-640-2-git-send-email-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 10, 2014 at 01:24:27PM +0800, Kefeng Wang wrote: > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > index 6bd4f66..573edb3 100644 > --- a/drivers/ata/libahci.c > +++ b/drivers/ata/libahci.c > @@ -452,6 +452,11 @@ void ahci_save_initial_config(struct device *dev, > cap &= ~HOST_CAP_SNTF; > } > > + if ((cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_NO_FBS)) { > + dev_info(dev, "controller can't do FBS, turning off CAP_FBS\n"); > + cap &= ~HOST_CAP_FBS; > + } Can you please put this chunk after YES_FBS? > if (!(cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_YES_FBS)) { > dev_info(dev, "controller can do FBS, turning on CAP_FBS\n"); > cap |= HOST_CAP_FBS; Thanks. -- tejun