From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jet Chen <jet.chen@intel.com>
Cc: Alessandro Rubini <rubini@gnudd.com>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] FMC: misc_register should not be called while atomic
Date: Wed, 16 Apr 2014 14:10:07 -0700 [thread overview]
Message-ID: <20140416211007.GA31451@kroah.com> (raw)
In-Reply-To: <1397016815-74608-1-git-send-email-jet.chen@intel.com>
On Wed, Apr 09, 2014 at 12:13:35PM +0800, Jet Chen wrote:
> Signed-off-by: Jet Chen <jet.chen@intel.com>
> ---
> drivers/fmc/fmc-chardev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fmc/fmc-chardev.c b/drivers/fmc/fmc-chardev.c
> index b071039..08c4549 100644
> --- a/drivers/fmc/fmc-chardev.c
> +++ b/drivers/fmc/fmc-chardev.c
> @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc)
> fc->misc.fops = &fc_fops;
> fc->misc.name = kstrdup(dev_name(&fmc->dev), GFP_KERNEL);
>
> - spin_lock(&fc_lock);
> ret = misc_register(&fc->misc);
> + spin_lock(&fc_lock);
> if (ret < 0) {
> kfree(fc->misc.name);
> kfree(fc);
> --
> 1.9.1
This patch doesn't apply at all, can you please redo it against 3.15-rc1
and resend it so that I can apply it?
thanks,
greg k-h
next prev parent reply other threads:[~2014-04-16 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 3:32 [FMC] BUG: scheduling while atomic: swapper/1/0x10000002 Jet Chen
2014-04-09 5:08 ` Alessandro Rubini
2014-04-09 5:26 ` Jet Chen
2014-04-09 5:28 ` Fengguang Wu
2014-04-09 16:44 ` Jet Chen
2014-04-09 16:46 ` Jet Chen
[not found] ` <1397016815-74608-1-git-send-email-jet.chen@intel.com>
2014-04-16 21:10 ` Greg Kroah-Hartman [this message]
2014-04-16 22:39 ` [PATCH] FMC: misc_register should not be called while atomic Alessandro Rubini
2014-04-17 3:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416211007.GA31451@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fengguang.wu@intel.com \
--cc=jet.chen@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome