From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, atodorov@redhat.com,
tony.luck@intel.com, gong.chen@linux.intel.com, bp@alien8.de,
jwboyer@fedoraproject.org, qmewlo@gmail.com, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/mce: Fix CMCI preemption bugs
Date: Thu, 17 Apr 2014 12:09:44 +0200 [thread overview]
Message-ID: <20140417100944.GG11096@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <tip-ea431643d6c38728195e2c456801c3ef66bb9991@git.kernel.org>
On Thu, Apr 17, 2014 at 02:57:54AM -0700, tip-bot for Ingo Molnar wrote:
> Commit-ID: ea431643d6c38728195e2c456801c3ef66bb9991
> Gitweb: http://git.kernel.org/tip/ea431643d6c38728195e2c456801c3ef66bb9991
> Author: Ingo Molnar <mingo@kernel.org>
> AuthorDate: Thu, 17 Apr 2014 10:25:53 +0200
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 17 Apr 2014 10:28:42 +0200
>
> x86/mce: Fix CMCI preemption bugs
>
> The following commit:
>
> 27f6c573e0f7 ("x86, CMCI: Add proper detection of end of CMCI storms")
>
> Added two preemption bugs:
>
> - machine_check_poll() does a get_cpu_var() without a matching
> put_cpu_var(), which causes preemption imbalance and crashes upon
> bootup.
>
> - it does percpu ops without disabling preemption. Preemption is not
> disabled due to the mistaken use of a raw spinlock.
it is arch_spinlock that doesn't disable preemption. raw_spinlock
disables preemption just fine.
next prev parent reply other threads:[~2014-04-17 10:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 9:57 tip-bot for Ingo Molnar
2014-04-17 10:09 ` Peter Zijlstra [this message]
2014-04-17 10:24 ` Borislav Petkov
2014-04-17 14:03 ` Luck, Tony
2014-04-17 15:26 ` Borislav Petkov
2014-04-17 16:54 ` Josh Boyer
2014-04-17 19:23 ` Borislav Petkov
2014-04-17 19:25 ` Linus Torvalds
2014-04-17 19:42 ` Borislav Petkov
2014-04-17 20:58 ` Borislav Petkov
[not found] ` <CAK7FoDt6tnknX7cioe7=2svVksyAyLUtoZX_oprzJNxoHZEpdw@mail.gmail.com>
2014-04-17 21:30 ` Borislav Petkov
2014-04-17 22:20 ` Borislav Petkov
2014-04-18 8:07 ` Ingo Molnar
2014-04-18 9:22 ` Borislav Petkov
2014-04-25 8:47 ` Chen, Gong
2014-04-25 13:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417100944.GG11096@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=atodorov@redhat.com \
--cc=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=qmewlo@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome