From: Tejun Heo <tj@kernel.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: lizefan@huawei.com, containers@lists.linux-foundation.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: clean up obsolete code and comment
Date: Thu, 17 Apr 2014 10:19:04 -0400 [thread overview]
Message-ID: <20140417141904.GH15326@htj.dyndns.org> (raw)
In-Reply-To: <1397744056-31119-1-git-send-email-nasa4836@gmail.com>
On Thu, Apr 17, 2014 at 10:14:16PM +0800, Jianyu Zhan wrote:
> This patch purely makes cleanup.
>
> 1. parse_cgroupfs_options() no longer takes refcounts on
> subsystems to be used, update its comment.
And cgroup_subsys[] doesn't require cgroup_mutex protection anymore.
That comment and BUG_ON(!mutex_is_locked()) can be removed. Can you
please separate these out into a separate patch?
> 2. cgroup_pidlist_seq_operations has no more user, remove it.
> 3. s/pr_warning/pr_warn/g, suggested by scripts/checkpatch.pl.
And let's put 2 and 3 in separate patches too.
> Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
Also, please regenerate the patches on top of the following branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-populated-v2
Thanks.
--
tejun
next prev parent reply other threads:[~2014-04-17 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 14:14 Jianyu Zhan
2014-04-17 14:19 ` Tejun Heo [this message]
2014-04-17 14:21 ` Jianyu Zhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417141904.GH15326@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=nasa4836@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®