From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v2 0/8] Reorder i.MX IPU display enable/disable sequence
Date: Fri, 18 Apr 2014 11:13:30 +0100 [thread overview]
Message-ID: <20140418101330.GC24070@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1397512403-19622-1-git-send-email-p.zabel@pengutronix.de>
On Mon, Apr 14, 2014 at 11:53:15PM +0200, Philipp Zabel wrote:
> Repeatedly enabling and disabling the display currently can lead to a state
> in which the IPU doesn't produce a valid signal anymore because we disable
> IPU submodules before they can finish their interaction.
>
> This series reorders the enable/disable sequence so that we first wait for the
> DC/DP to finish processing the current frame, then stop the DI and IDMAC, and
> only then disable clocks to the submodules. Also from now on we really disable
> the DC when it is not in use.
Okay, I'm going to queue these up in a couple of days, but there's
something which I'd prefer to be fixed... there's one in particular
that is excessively long.
> Philipp Zabel (8):
> imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts
> imx-drm: ipu-common: Add helpers to check for a busy IDMAC channel and
> to busywait for an interrupt
> imx-drm: ipu-dmfc: Wait for FIFOs to run empty before disabling
> imx-drm: ipu-dc: Wait for DC_FC_1 / DP_SF_END interrupt
> imx-drm: ipu-dp: Split disabling the DP foreground channel from
> disabling the DP module
> imx-drm: imx-dp: When disabling the DP foreground channel, wait until
> the DP background channel is finished before disabling the IDMAC
> channel
imx-drm: imx-dp: disable DP fg channel after DP bg channel has finished
maybe?
> imx-drm: ipuv3-crtc: Change display enable/disable order
> imx-drm: ipu-dc: Disable DC module when not in use
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
prev parent reply other threads:[~2014-04-18 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 21:53 Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 1/8] imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 2/8] imx-drm: ipu-common: Add helpers to check for a busy IDMAC channel and to busywait for an interrupt Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 3/8] imx-drm: ipu-dmfc: Wait for FIFOs to run empty before disabling Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 4/8] imx-drm: ipu-dc: Wait for DC_FC_1 / DP_SF_END interrupt Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 5/8] imx-drm: ipu-dp: Split disabling the DP foreground channel from disabling the DP module Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 6/8] imx-drm: imx-dp: When disabling the DP foreground channel, wait until the DP background channel is finished before disabling the IDMAC channel Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 7/8] imx-drm: ipuv3-crtc: Change display enable/disable order Philipp Zabel
2014-04-14 21:53 ` [PATCH v2 8/8] imx-drm: ipu-dc: Disable DC module when not in use Philipp Zabel
2014-04-14 22:18 ` [PATCH v2 0/8] Reorder i.MX IPU display enable/disable sequence Russell King - ARM Linux
2014-04-18 10:13 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418101330.GC24070@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®