From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbaDRK4j (ORCPT ); Fri, 18 Apr 2014 06:56:39 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59168 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbaDRK4i (ORCPT ); Fri, 18 Apr 2014 06:56:38 -0400 Date: Fri, 18 Apr 2014 12:56:01 +0200 From: Peter Zijlstra To: Vincent Guittot Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, fenghua.yu@intel.com, schwidefsky@de.ibm.com, cmetcalf@tilera.com, benh@kernel.crashing.org, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, dietmar.eggemann@arm.com, preeti@linux.vnet.ibm.com, linaro-kernel@lists.linaro.org Subject: Re: [PATCH v4 1/5] sched: rework of sched_domain topology definition Message-ID: <20140418105601.GU11182@twins.programming.kicks-ass.net> References: <1397209481-28542-1-git-send-email-vincent.guittot@linaro.org> <1397209481-28542-2-git-send-email-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1397209481-28542-2-git-send-email-vincent.guittot@linaro.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 11, 2014 at 11:44:37AM +0200, Vincent Guittot wrote: > We replace the old way to configure the scheduler topology with a new method > which enables a platform to declare additionnal level (if needed). > > We still have a default topology table definition that can be used by platform > that don't want more level than the SMT, MC, CPU and NUMA ones. This table can > be overwritten by an arch which either wants to add new level where a load > balance make sense like BOOK or powergating level or wants to change the flags > configuration of some levels. > > For each level, we need a function pointer that returns cpumask for each cpu, > a function pointer that returns the flags for the level and a name. Only flags > that describe topology, can be set by an architecture. The current topology > flags are: > SD_SHARE_CPUPOWER > SD_SHARE_PKG_RESOURCES > SD_NUMA > SD_ASYM_PACKING > > Then, each level must be a subset on the next one. The build sequence of the > sched_domain will take care of removing useless levels like those with 1 CPU > and those with the same CPU span and no more relevant information for > load balancing than its childs. > > Signed-off-by: Vincent Guittot > Reviewed-by: Preeti U Murthy On x86_64 defconfig this gets me: kernel/sched/core.c: In function 'sched_init_numa': kernel/sched/core.c:6197:4: warning: initialization makes pointer from integer without a cast [enabled by default] kernel/sched/core.c:6197:4: warning: (near initialization for '(anonymous).sd_flags') [enabled by default]