From: Mark Brown <broonie@kernel.org>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Shuge <shuge@allwinnertech.com>,
kevin@allwinnertech.com, Chen-Yu Tsai <wens@csie.org>,
Hans de Goede <hdegoede@redhat.com>,
Carlo Caione <carlo@caione.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dev@linux-sunxi.org
Subject: Re: [PATCH v2 2/2] regmap: i2c: fallback to SMBus if the adapter does not support standard I2C
Date: Fri, 18 Apr 2014 16:10:56 +0100 [thread overview]
Message-ID: <20140418151056.GY12304@sirena.org.uk> (raw)
In-Reply-To: <1397727612-32103-3-git-send-email-boris.brezillon@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
On Thu, Apr 17, 2014 at 11:40:12AM +0200, Boris BREZILLON wrote:
> +const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c,
> + const struct regmap_config *config)
Non-exported functions should be static. Otherwise this looks good
modulo the register size issue that Guenter identified.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-18 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 9:40 [PATCH v2 0/2] regmap: support regmap over SMBus Boris BREZILLON
2014-04-17 9:40 ` [PATCH v2 1/2] regmap: add reg_read/reg_write callbacks to regmap_bus struct Boris BREZILLON
2014-04-18 15:08 ` Mark Brown
2014-04-17 9:40 ` [PATCH v2 2/2] regmap: i2c: fallback to SMBus if the adapter does not support standard I2C Boris BREZILLON
2014-04-18 15:10 ` Mark Brown [this message]
2014-04-18 17:08 ` Lars-Peter Clausen
2014-04-18 20:11 ` [PATCH v3] " Boris BREZILLON
2014-04-19 1:57 ` Guenter Roeck
2014-04-21 20:56 ` [PATCH v4] " Boris BREZILLON
2014-04-22 11:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418151056.GY12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=boris.brezillon@free-electrons.com \
--cc=carlo@caione.org \
--cc=dev@linux-sunxi.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kevin@allwinnertech.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=shuge@allwinnertech.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®