From: Steven Rostedt <rostedt@goodmis.org>
To: Lin Yongting <linyongting@gmail.com>
Cc: fweisbec@gmail.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, linyongting@huawei.com
Subject: Re: [PATCH] tracing: Correct braces usage in if-else statement
Date: Sat, 19 Apr 2014 11:28:21 -0400 [thread overview]
Message-ID: <20140419112821.6ee5b104@gandalf.local.home> (raw)
In-Reply-To: <1397915903-21326-1-git-send-email-linyongting@gmail.com>
On Sat, 19 Apr 2014 21:58:23 +0800
Lin Yongting <linyongting@gmail.com> wrote:
> There are some incorrect braces usages in kernerl/trace/trace.c, including:
> 1. Missing braces in 'if' or 'else' branch.
> 2. Unnecessary braces in 'if' statement.
>
> Fix them according to kernel CodeStyle.
I understand that this is part of the CodeStyle, but I'm not accepting
this patch. It causes more pain than it is worth, as it makes it more
difficult to see git history because of "clean up" changes that get in
the way. I also honestly don't think this is much of a clean up.
Sorry,
-- Steve
>
> Signed-off-by: Lin Yongting <linyongting@gmail.com>
> ---
> kernel/trace/trace.c | 39 +++++++++++++++++++++++----------------
> 1 file changed, 23 insertions(+), 16 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
next prev parent reply other threads:[~2014-04-19 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 13:58 Lin Yongting
2014-04-19 15:28 ` Steven Rostedt [this message]
2014-04-19 17:09 ` ivan lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140419112821.6ee5b104@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyongting@gmail.com \
--cc=linyongting@huawei.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®