From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de,
jasowang@redhat.com, linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH net-next,1/2] hyperv: Remove recv_pkt_list and lock
Date: Mon, 21 Apr 2014 14:57:11 -0400 (EDT) [thread overview]
Message-ID: <20140421.145711.1903592201158395025.davem@davemloft.net> (raw)
In-Reply-To: <1398108376-4857-1-git-send-email-haiyangz@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Mon, 21 Apr 2014 12:26:15 -0700
> @@ -401,8 +401,6 @@ static void rndis_filter_receive_data(struct rndis_device *dev,
> pkt->total_data_buflen = rndis_pkt->data_len;
> pkt->data = (void *)((unsigned long)pkt->data + data_offset);
>
> - pkt->is_data_pkt = true;
> -
> vlan = rndis_get_ppi(rndis_pkt, IEEE_8021Q_INFO);
> if (vlan) {
> pkt->vlan_tci = VLAN_TAG_PRESENT | vlan->vlanid |
This part of your change is not explained at all in your commit message.
Please resubmit this series with this hunk properly described and
accounted for.
next prev parent reply other threads:[~2014-04-21 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 19:26 Haiyang Zhang
2014-04-21 18:57 ` David Miller [this message]
2014-04-21 21:00 ` Haiyang Zhang
2014-04-21 19:26 ` [PATCH net-next,2/2] hyperv: Simplify the send_completion variables Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421.145711.1903592201158395025.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®