From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159AbaDUSt5 (ORCPT ); Mon, 21 Apr 2014 14:49:57 -0400 Received: from imap.thunk.org ([74.207.234.97]:52140 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbaDUStu (ORCPT ); Mon, 21 Apr 2014 14:49:50 -0400 Date: Mon, 21 Apr 2014 14:48:41 -0400 From: "Theodore Ts'o" To: "Michael Kerrisk (man-pages)" Cc: Rich Felker , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, samba-technical@lists.samba.org, Ganesha NFS List , "Carlos O'Donell" , libc-alpha , "Stefan (metze) Metzmacher" , Christoph Hellwig Subject: Re: [PATCH] locks: rename file-private locks to file-description locks Message-ID: <20140421184841.GA5105@thunk.org> Mail-Followup-To: Theodore Ts'o , "Michael Kerrisk (man-pages)" , Rich Felker , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, samba-technical@lists.samba.org, Ganesha NFS List , Carlos O'Donell , libc-alpha , "Stefan (metze) Metzmacher" , Christoph Hellwig References: <1398087935-14001-1-git-send-email-jlayton@redhat.com> <20140421140246.GB26358@brightrain.aerifal.cx> <535529FA.8070709@gmail.com> <20140421161004.GC26358@brightrain.aerifal.cx> <5355644C.7000801@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5355644C.7000801@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 21, 2014 at 08:32:44PM +0200, Michael Kerrisk (man-pages) wrote: > So, can you *please* answer this question: what do you call (i.e., > what everyday technical language term do use for) the thing > that sits between a file descriptor and an i-node? > > (Please don't say 'struct file' -- that is not is an implementation > detail, and does not qualify as the kind of term that I could use > when documenting this feature in man pages.) At least in a few places, if you are going to use "file description", could you at least add a parenthetical comment: (commonly called a "struct file" by Linux kernel developers) Yes, it's an implementation detail, but it's one that's been around for over two decades, and IMHO highly unlikely to change in the future. So if you really want to use the POSIX terminology, it would probably be a good idea to also use the term of art which is in common use by the kernel developers, and I suspect has leaked out beyond that. I think it's actually a better and more functional name than what POSIX uses, so maybe the best compromise is to use both, to make sure there is no confusion. In particular, if we have text in the man pages where we have "file description" and "file descriptor" in the close proximity it would probably be good to add "(i.e., a struct file by Linux kernel developers)" just for clarity. Cheers, - Ted