From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Son P. Nguyen" <fastmutex@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Staging: dgnc: dgnc_driver: fixed dgnc_pci_tbl definition
Date: Tue, 22 Apr 2014 12:27:54 +0300 [thread overview]
Message-ID: <20140422092754.GA26890@mwanda> (raw)
In-Reply-To: <1398017139-22231-1-git-send-email-fastmutex@gmail.com>
I like the idea of this patch but the v2 version still doesn't compile.
I don't understand how you can write such a nice patch and not even test
that it compiles. Twice. That's not ok.
On Sun, Apr 20, 2014 at 06:05:38PM +0000, Son P. Nguyen wrote:
> From: "Son P. Nguyen" <fastmutex@gmail.com>
Don't include this when you are sending your own patch.
>
> Fixed dgnc_pci_tbl definition for correct coding style
This description is not enough.
>
> PS: This is for task 10 of eudyptula-challenge.
Don't include this line.
regards,
dan carpenter
prev parent reply other threads:[~2014-04-22 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 22:48 [PATCH 1/2] Staging: dgnc: dgnc_driver: fixed coding style of dgnc_pci_tbl Son P. Nguyen
2014-04-19 22:48 ` [PATCH 2/2] Staging: dgnc: dgnc_driver: fixed coding style braces Son P. Nguyen
2014-04-20 18:05 ` [PATCH v2 1/2] Staging: dgnc: dgnc_driver: fixed dgnc_pci_tbl definition Son P. Nguyen
2014-04-20 18:05 ` [PATCH v2 2/2] Staging: dgnc: dgnc_driver: fixed incorrect braces Son P. Nguyen
2014-04-22 9:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422092754.GA26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=fastmutex@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®