From: Rich Felker <dalias@libc.org>
To: Boaz Harrosh <openosd@gmail.com>
Cc: Jeff Layton <jlayton@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
samba-technical@lists.samba.org,
Ganesha NFS List <nfs-ganesha-devel@lists.sourceforge.net>,
libc-alpha <libc-alpha@sourceware.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
"Carlos O'Donell" <carlos@redhat.com>,
Stefan Metzmacher <metze@samba.org>,
Andy Lutomirski <luto@amacapital.net>,
Frank Filz <ffilzlnx@mindspring.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] locks: rename file-private locks to "open file description locks"
Date: Tue, 22 Apr 2014 11:00:56 -0400 [thread overview]
Message-ID: <20140422150056.GL26358@brightrain.aerifal.cx> (raw)
In-Reply-To: <5356808B.3040303@gmail.com>
On Tue, Apr 22, 2014 at 05:45:31PM +0300, Boaz Harrosh wrote:
> On 04/22/2014 03:23 PM, Jeff Layton wrote:
> <>
> >
> > We're going to have to live with these for a long time, so it's
> > important that we be happy with the names before we're stuck with them.
> > The consensus on the lists so far is that they should be rechristened as
> > "open file description locks".
> >
>
> I completely agree with the rename. (Though could you please post
> the rest of the rename patches for review)
>
> Just a very small nit. My native language is not English but I would
> rather you use "file-descriptor" (with an '-' as well) and not
> use "description" in the English name of the lock. This is
> because stated like that, "description" might refer to the
> locks and not to the file in the sentence. file-descriptor is
> more clear I think. (For me it was confusing at first before I realized
> what you meant)
I think you missed the whole point. "File descriptor" and "open file
description" have DIFFERENT meanings. Replacing one with the other
gives the wrong meaning.
Rich
prev parent reply other threads:[~2014-04-22 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 12:23 Jeff Layton
2014-04-22 14:45 ` Boaz Harrosh
2014-04-22 14:55 ` Jeff Layton
2014-04-22 15:05 ` Boaz Harrosh
2014-04-22 15:00 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422150056.GL26358@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=carlos@redhat.com \
--cc=ffilzlnx@mindspring.com \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=metze@samba.org \
--cc=mtk.manpages@gmail.com \
--cc=nfs-ganesha-devel@lists.sourceforge.net \
--cc=openosd@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®