mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Drew Richardson <drew.richardson@arm.com>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joe Perches <joe@perches.com>,
	Ben Greear <greearb@candelatech.com>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] Export irq tracepoints for use by kernel modules
Date: Tue, 22 Apr 2014 10:38:54 -0700	[thread overview]
Message-ID: <20140422173854.GA26894@dreric01-Precision-T1600> (raw)
In-Reply-To: <CA+5PVA7TFXdK-KjbwUtqMPF6=Ot1yhKycg5naV6N_gALWVN7cg@mail.gmail.com>

On Tue, Apr 22, 2014 at 04:01:03PM +0100, Josh Boyer wrote:
> On Tue, Apr 22, 2014 at 10:26 AM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Tue, Apr 22, 2014 at 07:24:20AM -0700, Drew Richardson wrote:
> >> After commit de7b2973903c6cc50b31ee5682a69b2219b9919d ("tracepoint:
> >> Use struct pointer instead of name hash for reg/unreg tracepoints"),
> >> any tracepoints used in a kernel module must be exported.
> >
> > How does this matter given that there aren't any modular users?
> 
> We had a bug report about this breaking systemtap type usage[1].  In
> there, Matthieu suggested that the new for_each_kernel_tracepoint
> interface be used.
> 
> Drew, it would have been proper to CC the author of the change you're
> referencing on all of your patches to export these symbols.
> 
> josh
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1087623
> 

Thanks Josh for pointing out that I should CC Mathieu and
register_tracepoint_module_notifier, which will work for me.

Drew

      reply	other threads:[~2014-04-22 17:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 14:24 Drew Richardson
2014-04-22 14:26 ` Christoph Hellwig
2014-04-22 15:00   ` Drew Richardson
2014-04-22 15:03     ` Christoph Hellwig
2014-04-22 15:01   ` Josh Boyer
2014-04-22 17:38     ` Drew Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422173854.GA26894@dreric01-Precision-T1600 \
    --to=drew.richardson@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=hch@infradead.org \
    --cc=joe@perches.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®