From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Zhu, Lejun" <lejun.zhu@linux.intel.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc_button_array: fix a crash during rmmod
Date: Tue, 22 Apr 2014 22:53:12 -0700 [thread overview]
Message-ID: <20140423055312.GB24854@core.coreip.homeip.net> (raw)
In-Reply-To: <53560E6F.9000806@linux.intel.com>
On Tue, Apr 22, 2014 at 02:38:39PM +0800, Zhu, Lejun wrote:
> When the system has zero or one button available, trying to rmmod
> soc_button_array will cause crash. Fix this by properly handling -ENODEV
> in probe().
>
> Signed-off-by: Lejun Zhu <lejun.zhu@linux.intel.com>
Applied, thank you.
> ---
> drivers/input/misc/soc_button_array.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/soc_button_array.c
> b/drivers/input/misc/soc_button_array.c
> index 08ead2a..20c80f5 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -169,6 +169,7 @@ static int soc_button_pnp_probe(struct pnp_dev *pdev,
> soc_button_remove(pdev);
> return error;
> }
> + continue;
> }
>
> priv->children[i] = pd;
> --
> 1.8.3.2
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
--
Dmitry
prev parent reply other threads:[~2014-04-23 5:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53560DD1.5050805@linux.intel.com>
2014-04-22 6:38 ` Zhu, Lejun
2014-04-23 5:53 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423055312.GB24854@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=lejun.zhu@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®