mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Rob Herring <robherring2@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linaro Patches <patches@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only
Date: Wed, 23 Apr 2014 14:15:08 +0100	[thread overview]
Message-ID: <20140423131508.6E53BC408D2@trevor.secretlab.ca> (raw)
In-Reply-To: <20140422140526.GK5904@bivouac.eciton.net>

On Tue, 22 Apr 2014 15:05:26 +0100, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Apr 22, 2014 at 02:08:29PM +0100, Grant Likely wrote:
> > > I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here.
> > 
> > I completely agree.
> 
> OK. So do we keep this around on unaffected architectures in perpetuity?
> 
> Or can there be some cut-off date when the majority of DT-enabled
> platforms can stop including this workaround which permits new incorrect
> DTs to be implemented so long as they are incorrect in this particular
> way?
> 
> > > Really, I would like to see quirks like this fixed up out of line from
> > > the normal flow somewhat like how PCI quirks are handled. So in this
> > > example, we would just add the missing property to the dtb for the
> > > broken platform before doing the memory scan. That does then require
> > > libfdt which is something I'm working on.
> > 
> > In fact, for Leif's purposes, I would rather have a flag when booting via
> > UEFI, and make the kernel skip the memory node parsing if the UEFI
> > memory map is available. Then the stub doesn't need to do any munging of
> > the DTB at all.
> 
> The reason for me doing that is because we (including you) agreed at
> the discussion held during LCU13 that this was the safest way of
> preventing "mischief" like userland trying to read information from
> /proc/device-tree...

I'm not the most consistent of people. I often change my mind and then
have no recollection of ever thinking differently.

Userland reading from /proc/device-tree isn't so much a problem, but
kernel drivers doing it might be.

But, regardless of whether or not the stub clears out the memory
nodes, it is still I think good practice for the kernel to make the
decision to ignore memory nodes, and not rely on them being cleared
correctly.

g.

  reply	other threads:[~2014-04-23 13:15 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 17:41 Leif Lindholm
2014-04-17 17:41 ` [PATCH 1/3] arm: dts: add device_type="memory" for ste-ccu8540 Leif Lindholm
2014-04-22  7:39   ` Lee Jones
2014-04-22 13:09     ` Grant Likely
2014-04-22 13:26   ` Linus Walleij
2014-05-15 14:50     ` Grant Likely
2014-04-17 17:42 ` [PATCH 2/3] mips: dts: add device_type="memory" where missing Leif Lindholm
2014-04-18 17:16   ` John Crispin
2014-04-22 13:13   ` Grant Likely
2014-05-15 14:50     ` Grant Likely
2014-04-17 17:42 ` [PATCH 3/3] of: Handle memory@0 node on PPC32 only Leif Lindholm
2014-04-18  8:04   ` Geert Uytterhoeven
2014-04-18 12:59     ` Leif Lindholm
2014-04-18 13:11       ` Geert Uytterhoeven
2014-04-21 12:56       ` Rob Herring
2014-04-23 10:35         ` Mark Rutland
2014-04-22 13:35       ` Grant Likely
2014-04-23 10:45         ` Mark Rutland
2014-04-23 11:14           ` Geert Uytterhoeven
2014-04-23 13:10           ` Grant Likely
2014-04-24  9:26             ` Leif Lindholm
2014-05-15 14:59               ` Grant Likely
2014-04-18  0:43 ` [PATCH 0/3] of: dts: enable memory@0 quirk for " Rob Herring
2014-04-18 12:48   ` Leif Lindholm
2014-04-18 15:37     ` Rob Herring
2014-04-18 20:13       ` Leif Lindholm
2014-04-18 21:28         ` Rob Herring
2014-04-19  0:36           ` Leif Lindholm
2014-04-22 13:08       ` Grant Likely
2014-04-22 14:05         ` Leif Lindholm
2014-04-23 13:15           ` Grant Likely [this message]
2014-04-23 17:25             ` Leif Lindholm
2014-04-23 13:17           ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140423131508.6E53BC408D2@trevor.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=patches@linaro.org \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®