mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ian Kent <raven@themaw.net>
Cc: autofs mailing list <autofs@vger.kernel.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] autofs - fix lockref lookup
Date: Wed, 23 Apr 2014 14:46:24 -0700	[thread overview]
Message-ID: <20140423144624.716f325d454f9debd97bef15@linux-foundation.org> (raw)
In-Reply-To: <20140423052035.5999.69412.stgit@perseus.fritz.box>

On Wed, 23 Apr 2014 13:20:36 +0800 Ian Kent <raven@themaw.net> wrote:

> autofs needs to be able to see private data dentry flags for
> its dentrys that are being created but not yet hashed and for
> its dentys that have been rmdir()ed but not yet freed. It
> needs to do this so it can block processes in these states
> until a status has been returned to indicate the given
> operation is complete.
> 
> It does this by keeping two lists, active and expring, of
> dentrys in this state and uses ->d_release() to keep them
> stable while it checks the reference count to determine
> if they should be used.
> 
> But with the recent lockref changes dentrys being freed
> sometimes don't transition to a reference count of 0 before
> being freed so autofs can occassionally use a dentry that
> is invalid which can lead to a panic.

What's the value of "recent"?  I assume 3.14 is OK?

  reply	other threads:[~2014-04-23 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23  5:20 Ian Kent
2014-04-23 21:46 ` Andrew Morton [this message]
2014-04-24  4:10   ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140423144624.716f325d454f9debd97bef15@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=autofs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raven@themaw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®