From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jean Pihet <jean.pihet@linaro.org>,
Josh Boyer <jwboyer@fedoraproject.org>,
Masanari Iida <standby24x7@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [GIT PULL 0/4] perf/urgent fixes
Date: Wed, 23 Apr 2014 16:53:25 +0200 [thread overview]
Message-ID: <20140423145325.GB27585@krava.brq.redhat.com> (raw)
In-Reply-To: <20140423131433.GB23224@gmail.com>
On Wed, Apr 23, 2014 at 03:14:33PM +0200, Ingo Molnar wrote:
>
> (Just reporting two bugs I found today - unrelated to your the
> perf/urgent pull request.)
>
> 1)
>
> Even when the most modern unwind library is found, the autodetection
> is spammy:
>
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... glibc: [ on ]
> ... gtk2: [ on ]
> ... libaudit: [ on ]
> ... libbfd: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libslang: [ on ]
> ... libunwind: [ on ]
> ... libdw-dwarf-unwind: [ on ]
> ... DWARF post unwind library: libunwind
>
> The 'DWARF post unwind library' line is somewhat superfluous. I
> realize that it prints out the library selected - but that's obvious
> from the 'libdw-dwarf-unwind' line above it already, right?
>
> Furthermore, it breaks the autodetection output format.
>
> 2)
>
> On latest Ubuntu (14.04) the tip:master build fails with:
>
> /usr/bin/ld: cannot find -liberty
> collect2: error: ld returned 1 exit status
>
> The autodetection sequence reports all green entries, so something's
> funky going on there.
we add -liberty once -lbfd is detected, I guess we
assumed that was common case
perf tools: fix BFD detection on opensuse
commit 280e7c48c3b873e4987a63da276ecab25383f494
Author: Andi Kleen <ak@linux.intel.com>
Date: Sat Jan 11 11:42:51 2014 -0800
could you please try patch below? it adds that only
if thats detected
'make VF=1' should display more status now
Andi,
could you please try that on opensuse?
thanks,
jirka
---
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index ee21fa9..f511658 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -186,7 +186,10 @@ VF_FEATURE_TESTS = \
stackprotector-all \
timerfd \
libunwind-debug-frame \
- bionic
+ bionic \
+ liberty \
+ liberty-z \
+ cplus-demangle
# Set FEATURE_CHECK_(C|LD)FLAGS-all for all CORE_FEATURE_TESTS features.
# If in the future we need per-feature checks/flags for features not
@@ -504,7 +507,21 @@ else
endif
ifeq ($(feature-libbfd), 1)
- EXTLIBS += -lbfd -lz -liberty
+ EXTLIBS += -lbfd
+
+ # call all detections now so we get correct
+ # status in VF output
+ $(call feature_check,liberty)
+ $(call feature_check,liberty-z)
+ $(call feature_check,cplus-demangle)
+
+ ifeq ($(feature-liberty), 1)
+ EXTLIBS += -lbfd -liberty
+ else
+ ifeq ($(feature-liberty-z), 1)
+ EXTLIBS += -lbfd -liberty -lz
+ endif
+ endif
endif
ifdef NO_DEMANGLE
@@ -515,15 +532,10 @@ else
CFLAGS += -DHAVE_CPLUS_DEMANGLE_SUPPORT
else
ifneq ($(feature-libbfd), 1)
- $(call feature_check,liberty)
- ifeq ($(feature-liberty), 1)
- EXTLIBS += -lbfd -liberty
- else
- $(call feature_check,liberty-z)
- ifeq ($(feature-liberty-z), 1)
- EXTLIBS += -lbfd -liberty -lz
- else
- $(call feature_check,cplus-demangle)
+ ifneq ($(feature-liberty), 1)
+ ifneq ($(feature-liberty-z), 1)
+ # we dont have neither HAVE_CPLUS_DEMANGLE_SUPPORT
+ # or any of 'bfd iberty z' trinity
ifeq ($(feature-cplus-demangle), 1)
EXTLIBS += -liberty
CFLAGS += -DHAVE_CPLUS_DEMANGLE_SUPPORT
next prev parent reply other threads:[~2014-04-23 14:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 11:31 Jiri Olsa
2014-04-23 11:31 ` [PATCH 1/4] perf tests x86: Fix memory leak in sample_ustack() Jiri Olsa
2014-04-23 11:31 ` [PATCH 2/4] perf tools: Disable libdw unwind for all but x86 arch Jiri Olsa
2014-04-23 11:31 ` [PATCH 3/4] tools lib traceevent: Fix backward compatibility macros for pevent filter enums Jiri Olsa
2014-04-23 11:31 ` [PATCH 4/4] tools lib traceevent: Fix memory leak in pretty_print() Jiri Olsa
2014-04-23 13:09 ` [GIT PULL 0/4] perf/urgent fixes Ingo Molnar
2014-04-23 13:14 ` Ingo Molnar
2014-04-23 13:49 ` Jiri Olsa
2014-04-24 6:36 ` Ingo Molnar
2014-04-24 11:47 ` Jiri Olsa
2014-04-25 8:12 ` Ingo Molnar
2014-04-23 14:53 ` Jiri Olsa [this message]
2014-04-24 6:47 ` Ingo Molnar
2014-04-24 11:43 ` Jiri Olsa
2014-04-25 17:50 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2018-06-02 14:59 Arnaldo Carvalho de Melo
2018-06-03 17:12 ` Ingo Molnar
2017-05-04 17:23 Arnaldo Carvalho de Melo
2017-05-04 17:44 ` Ingo Molnar
2016-01-26 14:32 Arnaldo Carvalho de Melo
2016-01-30 8:16 ` Ingo Molnar
2015-08-19 19:40 Arnaldo Carvalho de Melo
2015-08-20 9:48 ` Ingo Molnar
2015-07-09 15:45 Arnaldo Carvalho de Melo
2015-07-10 8:04 ` Ingo Molnar
2015-04-23 22:03 Arnaldo Carvalho de Melo
2015-04-24 2:02 ` Namhyung Kim
2015-04-24 2:09 ` Arnaldo Carvalho de Melo
2015-04-24 8:59 ` Javi Merino
2015-04-24 16:02 ` Arnaldo Carvalho de Melo
2015-04-24 16:05 ` Will Deacon
2015-01-03 2:55 Arnaldo Carvalho de Melo
2015-01-08 8:00 ` Ingo Molnar
2013-10-28 19:16 Arnaldo Carvalho de Melo
2013-10-29 8:10 ` Ingo Molnar
2012-05-30 0:11 Arnaldo Carvalho de Melo
2012-05-30 7:00 ` Ingo Molnar
2012-05-25 19:59 Arnaldo Carvalho de Melo
2012-05-25 21:46 ` Arnaldo Carvalho de Melo
2012-04-20 16:53 Arnaldo Carvalho de Melo
2012-04-25 7:08 ` Ingo Molnar
2012-03-01 17:25 Arnaldo Carvalho de Melo
2011-06-03 16:25 Arnaldo Carvalho de Melo
2011-06-04 10:13 ` Ingo Molnar
2011-06-04 10:29 ` Ingo Molnar
2010-12-16 12:00 Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423145325.GB27585@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jean.pihet@linaro.org \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®