mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: Don Zickus <dzickus@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	Namhyung Kim <namhyung@kernel.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH] perf tools: fix processing of pid/tid for mmap records
Date: Wed, 23 Apr 2014 17:42:11 +0200	[thread overview]
Message-ID: <20140423154211.GB2230@krava.brq.redhat.com> (raw)
In-Reply-To: <CABPqkBSt9N_05Lo-74Dk==_anj5Zh4+5b=26g63ozNvsWUJLVQ@mail.gmail.com>

On Wed, Apr 23, 2014 at 05:06:21PM +0200, Stephane Eranian wrote:

SNIP

> > That is probably the behaviour we both expect.
> >
> > Jiri's patch takes all mmap events as pid maps and creates an initial map
> > for them.  All future threads that don't have mappings will trying to use
> > their pid's mapping as a fallback option.
> >
> > Because it is all pointer based now, updating the pid mappings
> > automatically update all the thread mappings too.
> >
> > I believe this approach will is the right one and makes sense.  Do you
> > think that works for you?
> >
> I just tried Jiri's 5 patches and my JIT patches, and it does work correctly.
> My Java samples are correctly symbolized. So looks like we have a solution
> that works for both of us though it seems complicated. But I can live with it.
> Thanks Jiri.

can I take this for your Tested-by?

thanks,
jirka

      reply	other threads:[~2014-04-23 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 16:06 Stephane Eranian
2014-04-22 13:32 ` Jiri Olsa
2014-04-22 13:37   ` Stephane Eranian
2014-04-22 19:40 ` Don Zickus
2014-04-22 19:50   ` Stephane Eranian
2014-04-22 20:45     ` Don Zickus
2014-04-23 12:52       ` Stephane Eranian
2014-04-23 13:30         ` Don Zickus
2014-04-23 15:06           ` Stephane Eranian
2014-04-23 15:42             ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140423154211.GB2230@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome