From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757926AbaDWTAx (ORCPT ); Wed, 23 Apr 2014 15:00:53 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:46741 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756122AbaDWTAr (ORCPT ); Wed, 23 Apr 2014 15:00:47 -0400 Date: Wed, 23 Apr 2014 15:00:43 -0400 From: Tejun Heo To: Vivek Goyal Cc: Jens Axboe , linux-kernel@vger.kernel.org, Li Zefan , cgroups@vger.kernel.org Subject: Re: [PATCH RFC] blkcg: prepare blkcg knobs for default hierarchy Message-ID: <20140423190043.GB4163@mtj.dyndns.org> References: <20140413013209.GC26252@mtj.dyndns.org> <20140414180824.GB9552@redhat.com> <20140414193214.GC16835@htj.dyndns.org> <20140415135359.GA13033@redhat.com> <20140415140650.GI1863@htj.dyndns.org> <20140415141826.GB17018@redhat.com> <20140423170141.GJ4781@htj.dyndns.org> <20140423171720.GF24651@redhat.com> <20140423185231.GA4163@mtj.dyndns.org> <20140423185835.GD22755@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140423185835.GD22755@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Apr 23, 2014 at 02:58:35PM -0400, Vivek Goyal wrote: > Oh, sorry, I had misunderstood your question. > > - Number of IOs serviced will be different at throttling layer and > CFQ layer as throttling accounts IO in terms of bios and CFQ > accounts in terms of number of requests. But shouldn't it be possible to determine that from merged count? Or we can just expose both bio and request counts at block core layer. The point is that there's nothing controller specific about these stats. > - CFQ might not be operational on a device while throttling might be > on and one needs bytes stats. Yeah, so expose both from blkcg core as blkio.* stats. > - In a custom kernel throttling might not be on and CFQ is on and > one needs the stats. Ditto. Thanks. -- tejun