mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: matt.fleming@intel.com, hpa@zytor.com, akpm@linux-foundation.org,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ignore ,keep for efi earlyprintk
Date: Thu, 24 Apr 2014 17:36:58 +0800	[thread overview]
Message-ID: <20140424093658.GA7158@dhcp-16-198.nay.redhat.com> (raw)

earlyprint=efi,keep results a kernel hang after "Freeing unused kernel memory"

Actually efi earlyprintk is using __init functions such as early_ioremap etc.
Thus efi earlyconsole can not be kept.

So just ignore it and give out a warning to user.

Signed-off-by: Dave Young <dyoung@redhat.com>
---
 arch/x86/kernel/early_printk.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: linux-2.6/arch/x86/kernel/early_printk.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/early_printk.c
+++ linux-2.6/arch/x86/kernel/early_printk.c
@@ -237,8 +237,11 @@ static int __init setup_early_printk(cha
 		}
 #endif
 #ifdef CONFIG_EARLY_PRINTK_EFI
-		if (!strncmp(buf, "efi", 3))
-			early_console_register(&early_efi_console, keep);
+		if (!strncmp(buf, "efi", 3)) {
+			if (keep)
+				pr_warn("Ignoring ,keep for earlyprintk=efi\n");
+			early_console_register(&early_efi_console, 0);
+		}
 #endif
 
 		buf++;

             reply	other threads:[~2014-04-24  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24  9:36 Dave Young [this message]
2014-04-24 10:45 ` Ingo Molnar
2014-04-25  1:53   ` Dave Young
2014-04-25 11:53 ` Matt Fleming
2014-04-26  7:28   ` Dave Young
2014-04-29  9:45     ` Matt Fleming
2014-04-29 10:03       ` Dave Young
2014-04-29 10:21       ` Thomas Gleixner
2014-04-30  1:12         ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140424093658.GA7158@dhcp-16-198.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®