From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [for-next][PATCH 5/7] ktest: Remove unused functions
Date: Thu, 24 Apr 2014 12:06:31 -0400 [thread overview]
Message-ID: <20140424160851.071881458@goodmis.org> (raw)
In-Reply-To: <20140424160626.491010573@goodmis.org>
[-- Attachment #1: 0005-ktest-Remove-unused-functions.patch --]
[-- Type: text/plain, Size: 2676 bytes --]
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
After the rewrite of the config bisect, there were several unused
functions that can be removed.
One of the unused functions printed out the failed config nicer than
what the rewrite did, so I kept that and used it to output the
bad config.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
tools/testing/ktest/ktest.pl | 63 +-------------------------------------------
1 file changed, 1 insertion(+), 62 deletions(-)
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 59697ea..8805668 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -2807,27 +2807,6 @@ sub process_config_ignore {
assign_configs \%config_ignore, $config;
}
-sub read_current_config {
- my ($config_ref) = @_;
-
- %{$config_ref} = ();
- undef %{$config_ref};
-
- my @key = keys %{$config_ref};
- if ($#key >= 0) {
- print "did not delete!\n";
- exit;
- }
- open (IN, "$output_config");
-
- while (<IN>) {
- if (/^(CONFIG\S+)=(.*)/) {
- ${$config_ref}{$1} = $2;
- }
- }
- close(IN);
-}
-
sub get_dependencies {
my ($config) = @_;
@@ -2947,23 +2926,6 @@ sub run_config_bisect_test {
return run_bisect_test $type, "oldconfig";
}
-sub process_passed {
- my (%configs) = @_;
-
- doprint "These configs had no failure: (Enabling them for further compiles)\n";
- # Passed! All these configs are part of a good compile.
- # Add them to the min options.
- foreach my $config (keys %configs) {
- if (defined($config_list{$config})) {
- doprint " removing $config\n";
- $config_ignore{$config} = $config_list{$config};
- delete $config_list{$config};
- }
- }
- doprint "config copied to $outputdir/config_good\n";
- run_command "cp -f $output_config $outputdir/config_good";
-}
-
sub process_failed {
my ($config) = @_;
@@ -3066,7 +3028,7 @@ sub run_config_bisect {
if (!$runtest && $len_diff > 0) {
if ($len_diff == 1) {
- doprint "The bad config setting is: $diff_arr[0]\n";
+ process_failed $diff_arr[0];
return 1;
}
my %tmp_config = %bad_configs;
@@ -3471,29 +3433,6 @@ sub read_depends {
read_kconfig($kconfig);
}
-sub read_config_list {
- my ($config) = @_;
-
- open (IN, $config)
- or dodie "Failed to read $config";
-
- while (<IN>) {
- if (/^((CONFIG\S*)=.*)/) {
- if (!defined($config_ignore{$2})) {
- $config_list{$2} = $1;
- }
- }
- }
-
- close(IN);
-}
-
-sub read_output_config {
- my ($config) = @_;
-
- assign_configs \%config_ignore, $config;
-}
-
sub make_new_config {
my @configs = @_;
--
1.8.5.3
next prev parent reply other threads:[~2014-04-24 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 16:06 [for-next][PATCH 0/7] ktest: A working config-bisect and other updates Steven Rostedt
2014-04-24 16:06 ` [for-next][PATCH 1/7] ktest: add 2nd parameter of run_command() to set the redirect target file Steven Rostedt
2014-04-24 16:06 ` [for-next][PATCH 2/7] ktest: Some cleanup for improving readability Steven Rostedt
2014-04-24 16:06 ` [for-next][PATCH 3/7] ktest: Rewrite the config-bisect to actually work Steven Rostedt
2014-04-24 16:06 ` [for-next][PATCH 4/7] ktest: Put back in the CONFIG_BISECT_CHECK Steven Rostedt
2014-04-24 16:06 ` Steven Rostedt [this message]
2014-04-24 16:06 ` [for-next][PATCH 6/7] ktest: Add the config bisect manual back Steven Rostedt
2014-04-24 16:06 ` [for-next][PATCH 7/7] ktest: Update documentation on config_bisect Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424160851.071881458@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®