From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Anders Berg <anders.berg@lsi.com>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
Mike Turquette <mturquette@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] ARM: dts: Device tree for AXM55xx.
Date: Fri, 25 Apr 2014 12:54:13 +0100 [thread overview]
Message-ID: <20140425115413.GL26756@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CACRpkdaqPx3=qvUtsg44rBk+ZiscUg54HmNgETcei0LzfE9uOQ@mail.gmail.com>
On Fri, Apr 25, 2014 at 01:50:25PM +0200, Linus Walleij wrote:
> This means that you can only get a proper, working IRQ from the
> first line on gpio0 right? All other IRQs will be ignored.
>
> I see no problem in augmenting the driver to handle this
> if #irqs == 8, the big change needs to happen in drivers/amba/bus.c
> that has no way to pass any more than two IRQs atm.
>
> I guess the best is to augment struct amba_device with a field
> struct resource *resource and num_resources like platform_device
> instead of the hard-coded single resource for iomem and two
> hardcoded IRQ placeholders, so that an arbitrary amount of
> resources can be added to an amba_device as well. But that
> may be quite a lot of work. (Russell will know which direction to
> take here.)
I definitely don't want to go down that route - I believe that the
resource arrays are more pain than they're really worth - it requires
a great amount of support to make that stuff work (just look at the
amount of code there is to search the arrays, create them, etc.)
We already have support for up to 9 IRQs, so 8 for GPIOs is already
catered for.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-04-25 11:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 10:44 [PATCH v2 0/6] Add platform support for LSI AXM55xx Anders Berg
2014-04-24 10:44 ` [PATCH v2 1/6] ARM: Add platform support for LSI AXM55xx SoC Anders Berg
2014-04-24 10:52 ` Russell King - ARM Linux
2014-04-24 10:44 ` [PATCH v2 2/6] clk: Add clock driver for " Anders Berg
2014-05-08 9:54 ` Anders Berg
2014-04-24 10:44 ` [PATCH v2 3/6] ARM: dts: Device tree for AXM55xx Anders Berg
2014-04-24 13:24 ` Linus Walleij
2014-04-24 17:47 ` Anders Berg
2014-04-25 9:16 ` Linus Walleij
2014-04-25 9:43 ` Anders Berg
2014-04-25 11:50 ` Linus Walleij
2014-04-25 11:54 ` Russell King - ARM Linux [this message]
2014-04-28 9:41 ` Anders Berg
2014-04-24 10:44 ` [PATCH v2 4/6] ARM: axxia: Adding defconfig " Anders Berg
2014-04-24 10:44 ` [PATCH v2 5/6] power: reset: Add Axxia system reset driver Anders Berg
2014-04-24 10:44 ` [PATCH v2 6/6] ARM: dts: axxia: Add reset controller Anders Berg
2014-05-05 8:35 ` [PATCH v2 0/6] Add platform support for LSI AXM55xx Anders Berg
2014-05-13 8:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425115413.GL26756@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=anders.berg@lsi.com \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®