From: Sebastian Reichel <sre@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Shubhrajyoti Datta" <omaplinuxkernel@gmail.com>,
"Carlos Chinea" <cch.devel@gmail.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kumar Gala" <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>,
"Ивайло Димитров" <freemangordon@abv.bg>,
"Joni Lapilainen" <joni.lapilainen@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Carlos Chinea" <carlos.chinea@nokia.com>
Subject: Re: [PATCHv3 10/14] HSI: Introduce driver for SSI Protocol
Date: Fri, 25 Apr 2014 20:49:01 +0200 [thread overview]
Message-ID: <20140425184900.GF22721@earth.universe> (raw)
In-Reply-To: <20140419194936.GJ5148@amd.pavel.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]
On Sat, Apr 19, 2014 at 09:49:36PM +0200, Pavel Machek wrote:
> Hi!
>
> > This adds a driver for the SSI McSAAB protocol as used in
> > the Nokia N900.
> >
> > Signed-off-by: Carlos Chinea <carlos.chinea@nokia.com>
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
>
> > +#define SSIP_MIN_PN_HDR 6 /* FIXME: Revisit */
> > +#define SSIP_WDTOUT 2000 /* FIXME: has to be 500 msecs> */
>
> Can they be fixed now, or do they have to wait?
I would prefer to wait. The timing above works and having it in the
git history doesn't hurt.
> > +#ifdef __LITTLE_ENDIAN
> > + ((u16 *)skb->data)[2] = swab16(((u16 *)skb->data)[2]);
> > + dev_dbg(&dev->dev, "RX length fixed (%04x -> %u)\n",
> > + ((u16 *)skb->data)[2], ntohs(((u16 *)skb->data)[2]));
> > +#endif
>
> Uh. Can this be replaced by
> ((u16 *)skb->data)[2] = htons(((u16 *)skb->data)[2]);
>
> (without the ifdef?)
Yes.
> > + /*
> > + * Modem sends Phonet messages over SSI with its own endianess...
> > + * Assume that modem has the same endianess as we do.
> > + */
> > + if (skb_cow_head(skb, 0))
> > + goto drop;
> > +#ifdef __LITTLE_ENDIAN
> > + ((u16 *)skb->data)[2] = swab16(((u16 *)skb->data)[2]);
> > +#endif
>
> Here, too?
Fixed in PATCHv4.
> But it looks like the comment does not match the code, because we
> swap.
The swap only converts the package length field from/to network byte
order. I think the comment still applies for the other actual message.
I added a comment for the length field and kept the other comment as
is for PATCHv4.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-04-25 18:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 0:31 [PATCHv3 00/14] OMAP SSI driver / N900 modem support Sebastian Reichel
2014-03-29 0:31 ` [PATCHv3 01/14] Documentation: HSI: Add some general description for the HSI subsystem Sebastian Reichel
2014-04-19 19:05 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 02/14] MAINTAINERS: update HSI entry Sebastian Reichel
2014-04-19 19:06 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 03/14] HSI: hsi-char: fix driver for multiport scenarios Sebastian Reichel
2014-04-19 19:06 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 04/14] HSI: method to unregister clients from an hsi port Sebastian Reichel
2014-04-19 19:07 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 05/14] HSI: Add channel resource support to HSI clients Sebastian Reichel
2014-04-19 19:11 ` Pavel Machek
2014-04-25 17:32 ` Sebastian Reichel
2014-03-29 0:31 ` [PATCHv3 06/14] HSI: export method to (un)register clients Sebastian Reichel
2014-04-19 19:13 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 07/14] HSI: Add common DT binding for HSI client devices Sebastian Reichel
2014-04-19 19:16 ` Pavel Machek
2014-04-25 18:25 ` Sebastian Reichel
2014-04-25 20:59 ` Sebastian Reichel
2014-04-27 10:57 ` Pavel Machek
2014-04-27 11:33 ` Sebastian Reichel
2014-04-21 16:52 ` Rob Herring
2014-04-25 18:32 ` Sebastian Reichel
2014-03-29 0:31 ` [PATCHv3 08/14] HSI: Introduce OMAP SSI driver Sebastian Reichel
2014-04-19 19:30 ` Pavel Machek
2014-04-25 18:36 ` Sebastian Reichel
2014-03-29 0:31 ` [PATCHv3 09/14] Documentation: DT: omap-ssi binding documentation Sebastian Reichel
2014-04-19 19:32 ` Pavel Machek
2014-04-21 16:43 ` Rob Herring
2014-04-25 18:38 ` Sebastian Reichel
2014-03-29 0:31 ` [PATCHv3 10/14] HSI: Introduce driver for SSI Protocol Sebastian Reichel
2014-04-19 19:49 ` Pavel Machek
2014-04-25 18:49 ` Sebastian Reichel [this message]
2014-03-29 0:31 ` [PATCHv3 11/14] HSI: Introduce Nokia N900 modem driver Sebastian Reichel
2014-04-19 20:25 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 12/14] ARM: dts: omap3 clocks: simplify ssi aliases Sebastian Reichel
2014-04-19 20:26 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 13/14] DTS: ARM: OMAP3-N900: Add SSI support Sebastian Reichel
2014-04-19 20:28 ` Pavel Machek
2014-03-29 0:31 ` [PATCHv3 14/14] DTS: ARM: OMAP3-N900: Add modem support Sebastian Reichel
2014-04-19 20:28 ` Pavel Machek
2014-05-05 19:31 ` [PATCHv3 00/14] OMAP SSI driver / N900 " Tony Lindgren
2014-05-05 22:41 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425184900.GF22721@earth.universe \
--to=sre@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=carlos.chinea@nokia.com \
--cc=cch.devel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=freemangordon@abv.bg \
--cc=galak@codeaurora.org \
--cc=joni.lapilainen@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=omaplinuxkernel@gmail.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®