From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640AbaDYU7h (ORCPT ); Fri, 25 Apr 2014 16:59:37 -0400 Received: from mail.kernel.org ([198.145.19.201]:36511 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465AbaDYU7d (ORCPT ); Fri, 25 Apr 2014 16:59:33 -0400 Date: Fri, 25 Apr 2014 22:59:27 +0200 From: Sebastian Reichel To: Pavel Machek Cc: Linus Walleij , Shubhrajyoti Datta , Carlos Chinea , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , Joni Lapilainen , Aaro Koskinen Subject: Re: [PATCHv3 07/14] HSI: Add common DT binding for HSI client devices Message-ID: <20140425205926.GA30032@earth.universe> References: <1396053110-21639-1-git-send-email-sre@kernel.org> <1396053110-21639-8-git-send-email-sre@kernel.org> <20140419191612.GG5148@amd.pavel.ucw.cz> <20140425182535.GB22721@earth.universe> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <20140425182535.GB22721@earth.universe> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 25, 2014 at 08:25:36PM +0200, Sebastian Reichel wrote: > On Sat, Apr 19, 2014 at 09:16:12PM +0200, Pavel Machek wrote: > > On Sat 2014-03-29 01:31:43, Sebastian Reichel wrote: > > > Implement and document generic DT bindings for HSI clients. > > >=20 > > > Signed-off-by: Sebastian Reichel > >=20 > > Reviewed-by: Pavel Machek > >=20 > > > diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c > > > index 07e1639..5973906 100644 > > > --- a/drivers/hsi/hsi.c > > > +++ b/drivers/hsi/hsi.c > > > @@ -26,8 +26,14 @@ > > > #include > > > #include > > > #include > > > +#include > > > +#include > > > #include "hsi_core.h" > >=20 > >=20 > > > + err =3D hsi_of_property_parse_mode(client, "hsi-mode", &mode); > > > + if (err) { > > > + err =3D hsi_of_property_parse_mode(client, "hsi-rx-mode", > > > + &cl->rx_cfg.mode); > > > + if (err) > > > + goto err; > > > + > > > + err =3D hsi_of_property_parse_mode(client, "hsi-tx-mode", > > > + &cl->tx_cfg.mode); > > > + if (err) > > > + goto err; > >=20 > > Will this need some #ifdef CONFIG_OF? >=20 > It would only be needed to reduce the amount of kernel code for > disabled Device Tree. I don't think its worth it, since there is no > platform in the mainline kernel, which uses HSI without DT. mh actually it is needed, since there is no stub provided for of_modalias_node in non DT mode (there are stubs for all other of_* methods used). I will include the ifdef in PATCHv5. -- Sebastian --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJTWsyuAAoJENju1/PIO/qakcEP/j+5K9uSIBjRtbyAKjaLqIqK AqH+qlv5IfUo8pI06LmIqAfno2BOvTN8SGjG8vPaJB6ObA4q34LRhmWwyIZxP9fX 7pGY+ELRoICAIgRatVmAO/Qf2+cNhcfXkLh0fYTBJwOxq+qo+9FQWXmTp3VeI23o 3kTLorhBq4PrO7zpay3H9FllclvwUxZ27iIajku5+Hofe38joWqYtfhBow9/0LsL wk5xL7rEhqJudgiOjBm+SBx0kTssxLXaUTV3fUeII2L9997TQzJ8TjdiCQBGsqQg NZuHy18wpaFwcPH9qVein1A9CqKCko9fr9AEE03366c4yO6rJWeoIj7t2XQZtGwG JoAFvtlxq2kNWvAnfM3RGZqxHSDF2Azofm9wqZZSSJCojzwZ1JrURJ+nJlmFZQnM KXq/+e5Pnmsuy5AzLyG5diIclBgcTKW+fd2vycaaB8rC546xjQwN+VWalgApGylV nT7OG3m93Ytw9+XClz4oPPxIiaCiH05iMIUVkebk0BWKJwUvZDyMepR2WzGMHqSs CXsKPCu8ElOFQWaZuvlXiVUJN6MB6lJxjdXqcAXgzEJKm2LKTG27NpY1kt2JhiYz 7qOO1MUUOsGzXEp3S9l+bkJ7NXGLByMoLuyCRfBVd6kqm37vCH2UijNICsaC06JR mmQrl5kcwqYgxyCbU5wI =XRjv -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--