From: Greg KH <gregkh@linuxfoundation.org>
To: Tair <tair.rzayev@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: keucr: smilmain.c: Fix sparse warning
Date: Fri, 25 Apr 2014 15:24:59 -0700 [thread overview]
Message-ID: <20140425222459.GA25868@kroah.com> (raw)
In-Reply-To: <53555897.10409@gmail.com>
On Mon, Apr 21, 2014 at 08:42:47PM +0300, Tair wrote:
> From: Tair Rzayev <tair.rzayev@gmail.com>
>
> Fix "Should be static" sparse warning:
> * Add Check_D_MediaFmt() declaration to smil.h;
> * Move Check_D_MediaFmt() implementation up in smilmain.c to keep
> all the non-static functions at the top of the file;
> * Include "init.h" into "smil.h", remove externs from "smil.h"
> which are no longer needed;
> * SM_Init[] and SM_Rdwr[] are renamed because otherwise SM_Init[]
> collides with SM_Init() from "smil.h".
That's a lot of things to do all at once.
In fact, it doesn't apply to my tree anymore because someone else just
did a part of what you did, so this might not be needed anymore. Can
you please rebase your patch on top of my staging-next branch on the
staging.git tree on git.kernel.org and resend it?
thanks,
greg k-h
next prev parent reply other threads:[~2014-04-25 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 17:42 Tair
2014-04-25 22:24 ` Greg KH [this message]
2014-05-03 20:00 ` [PATCH v2] " Tair Rzayev
2014-05-04 0:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425222459.GA25868@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tair.rzayev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome