From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Dmitry Eremin <dmitry.eremin@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>
Subject: Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference
Date: Sun, 27 Apr 2014 23:05:48 +0100 [thread overview]
Message-ID: <20140427230548.347fbb21@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1398633446-16719-2-git-send-email-green@linuxhacker.ru>
> Reviewed-by: John L. Hammond <john.hammond@intel.com>
> Reviewed-by: Isaac Huang <he.huang@intel.com>
> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> index 21d36ee..516f623 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> @@ -829,14 +829,14 @@ ksocknal_select_ips(ksock_peer_t *peer, __u32 *peerips, int n_peerips)
> best_npeers = iface->ksni_npeers;
> }
>
> + LASSERT(best_iface != NULL);
> +
And this solves the problem how ???
These dont' appear that helpful. If we dereference a NULL point we'll
already get a suitably spectacular oops and call trace dump.
Alan
next prev parent reply other threads:[~2014-04-27 22:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 21:17 [PATCH 0/5] Lustre Klocwork fixes Oleg Drokin
2014-04-27 21:17 ` [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference Oleg Drokin
2014-04-27 22:05 ` One Thousand Gnomes [this message]
2014-04-27 22:19 ` Oleg Drokin
2014-04-27 22:38 ` Greg Kroah-Hartman
2014-04-27 21:17 ` [PATCH 2/5] staging/lustre/lnet: remove unused variable Oleg Drokin
2014-04-27 21:17 ` [PATCH 3/5] staging/lustre/lnet: fix potential null pointer dereference Oleg Drokin
2014-04-27 22:40 ` Greg Kroah-Hartman
2014-04-27 21:17 ` [PATCH 4/5] " Oleg Drokin
2014-04-27 21:17 ` [PATCH 5/5] " Oleg Drokin
2014-04-27 22:39 ` Greg Kroah-Hartman
2014-04-27 23:28 ` Oleg Drokin
2014-04-27 22:37 ` [PATCH 0/5] Lustre Klocwork fixes Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140427230548.347fbb21@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=green@linuxhacker.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome