From: David Miller <davem@davemloft.net>
To: kys@microsoft.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
jasowang@redhat.com, stable@kernel.org
Subject: Re: [PATCH V1 net-next 1/1] hyperv: Properly handle checksum offload
Date: Mon, 28 Apr 2014 13:23:47 -0400 (EDT) [thread overview]
Message-ID: <20140428.132347.778081265367223580.davem@davemloft.net> (raw)
In-Reply-To: <1398484523-27596-1-git-send-email-kys@microsoft.com>
From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Fri, 25 Apr 2014 20:55:23 -0700
> @@ -467,6 +467,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
> if (skb_is_gso(skb))
> goto do_lso;
>
> + if (skb->ip_summed != CHECKSUM_PARTIAL)
> + goto do_send;
> +
There are many possible values of ip_summed, why would you go to do_send if
for example it was set to CHECKSUM_COMPLETE?
I think you are just rushing this change, take your time and implement the
fix properly.
For example, if you only expect two possible values here (CHECKSUM_PARTIAL
and something else), design your test so that it only allows those two
values and therefore you'll be documenting this invariant.
next prev parent reply other threads:[~2014-04-28 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 3:55 K. Y. Srinivasan
2014-04-28 17:23 ` David Miller [this message]
2014-04-28 18:31 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428.132347.778081265367223580.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®