From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Matt Porter <mporter@linaro.org>
Cc: Barry Song <baohua@kernel.org>, Kevin Hilman <khilman@linaro.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes
Date: Mon, 28 Apr 2014 10:15:33 +0100 [thread overview]
Message-ID: <20140428091532.GG26756@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1398644860-22973-1-git-send-email-mporter@linaro.org>
On Sun, Apr 27, 2014 at 08:27:40PM -0400, Matt Porter wrote:
> l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init()
> early initcall. In a multi v7 kernel this causes bcm281xx and bcm21664
> platform to fail boot since they have their own pre l2x0 init sequence
> that is required. Fix this by checking that a matching OF ID is present
> before calling l2x0_of_init().
>
> Reported-by: Kevin Hilman <khilman@linaro.org>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> ---
> Applies against next-20140424 to fix the issue introduced in
> 50655e6 ARM: l2c: prima2: remove cache size override
Err, this only "fixes" it because it effectively disables the L2 cache
_entirely_ - in the above commit, I kill your private compatible strings.
This doesn't make sense. If the cache is already enabled, then the L2C
code won't try to enable it again.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-04-28 9:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 0:27 Matt Porter
2014-04-28 9:15 ` Russell King - ARM Linux [this message]
2014-04-28 13:40 ` Matt Porter
2014-04-29 15:10 ` Barry Song
2014-04-28 14:29 ` Felipe Balbi
2014-04-28 14:37 ` Matt Porter
2014-04-28 14:52 ` Russell King - ARM Linux
2014-04-29 15:05 ` Barry Song
2014-04-29 15:14 ` Russell King - ARM Linux
2014-04-29 15:40 ` Barry Song
2014-05-22 9:33 ` Russell King - ARM Linux
2014-05-22 11:04 ` Barry Song
2014-05-22 11:27 ` Russell King - ARM Linux
2014-05-22 11:39 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428091532.GG26756@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=baohua@kernel.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®