From: hch <hch@infradead.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, jack <jack@suse.cz>,
hch <hch@infradead.org>, Viro <viro@zeniv.linux.org.uk>,
tytso <tytso@mit.edu>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH V2 1/2] FS: Add generic data flush to fsync
Date: Mon, 28 Apr 2014 04:49:27 -0700 [thread overview]
Message-ID: <20140428114927.GB9522@infradead.org> (raw)
In-Reply-To: <20140426005424.9268324f9911e60a0e20cb59@skynet.be>
> + if (flush == true) {
> + err = blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL,
> + NULL);
> + if (ret == 0)
> + ret = err;
> + }
> +
> out:
> mutex_unlock(&inode->i_mutex);
There is no need to have the cache flush under i_mutex, and thus there's
also no need to have the parameter, as the flush can be done in
generic_file_fsync.
prev parent reply other threads:[~2014-04-28 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 22:54 Fabian Frederick
2014-04-28 11:49 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428114927.GB9522@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®