From: Matt Fleming <matt@console-pimps.org>
To: Borislav Petkov <bp@suse.de>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
ricardo.neri-calderon@linux.intel.com, tglx@linutronix.de,
matt.fleming@intel.com, linux-tip-commits@vger.kernel.org,
Seiji Aguchi <seiji.aguchi@hds.com>
Subject: Re: [tip:x86/efi] x86/efi: Save and restore FPU context around efi_calls (x86_64)
Date: Tue, 29 Apr 2014 11:46:16 +0100 [thread overview]
Message-ID: <20140429104616.GF26088@console-pimps.org> (raw)
In-Reply-To: <20140425114010.GA20275@nazgul.tnic>
On Fri, 25 Apr, at 01:40:10PM, Borislav Petkov wrote:
>
> Well, the more I think about it, the more I'm persuaded that
> you actually do *really* need that WARN_ON_ONCE check there to
> make sure you're not fiddling with the FPU while in an interrupt
> context and in an unsafe way (see interrupted_kernel_fpu_idle() and
> interrupted_user_mode()). And so you do need the variants without the
> "__" which include the check.
>
> Anyway, here it is, do give it a good run:
Thanks Borislav, I gave this a run on my machines and everything appears
to be fine. I'll probably send it to tip by the end of the week, I'm
just gonna let it stew on my 'next' branch for a while.
--
Matt Fleming, Intel Open Source Technology Center
prev parent reply other threads:[~2014-04-29 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-de05764e0b2a3d9559e099a2e134f8cef4500fdd@git.kernel.org>
2014-04-20 0:28 ` Borislav Petkov
2014-04-25 11:09 ` Matt Fleming
2014-04-25 11:40 ` Borislav Petkov
2014-04-29 10:46 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429104616.GF26088@console-pimps.org \
--to=matt@console-pimps.org \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome