From: Rik van Riel <riel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, sandeen@redhat.com,
akpm@linux-foundation.org, jweiner@redhat.com,
kosaki.motohiro@jp.fujitsu.com, mhocko@suse.cz,
fengguang.wu@intel.com, mpatlasov@parallels.com
Subject: [PATCH] mm,writeback: fix divide by zero in pos_ratio_polynom
Date: Tue, 29 Apr 2014 15:19:10 -0400 [thread overview]
Message-ID: <20140429151910.53f740ef@annuminas.surriel.com> (raw)
It is possible for "limit - setpoint + 1" to equal zero, leading to a
divide by zero error. Blindly adding 1 to "limit - setpoint" is not
working, so we need to actually test the divisor before calling div64.
Signed-off-by: Rik van Riel <riel@redhat.com>
Cc: stable@vger.kernel.org
---
mm/page-writeback.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index ef41349..2682516 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -597,11 +597,16 @@ static inline long long pos_ratio_polynom(unsigned long setpoint,
unsigned long dirty,
unsigned long limit)
{
+ unsigned int divisor;
long long pos_ratio;
long x;
+ divisor = limit - setpoint;
+ if (!divisor)
+ divisor = 1;
+
x = div_s64(((s64)setpoint - (s64)dirty) << RATELIMIT_CALC_SHIFT,
- limit - setpoint + 1);
+ divisor);
pos_ratio = x;
pos_ratio = pos_ratio * x >> RATELIMIT_CALC_SHIFT;
pos_ratio = pos_ratio * x >> RATELIMIT_CALC_SHIFT;
next reply other threads:[~2014-04-29 19:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 19:19 Rik van Riel [this message]
2014-04-29 19:43 ` Motohiro Kosaki
2014-04-29 22:39 ` Andrew Morton
2014-04-29 22:48 ` Rik van Riel
2014-04-29 22:53 ` Andrew Morton
2014-04-30 8:04 ` Maxim Patlasov
2014-04-30 8:12 ` Michal Hocko
2014-04-30 8:34 ` Maxim Patlasov
2014-04-30 10:01 ` Masayoshi Mizuma
2014-04-30 13:30 ` [PATCH v2] " Rik van Riel
2014-04-30 13:48 ` Michal Hocko
2014-04-30 14:26 ` Rik van Riel
2014-04-30 14:31 ` Rik van Riel
2014-04-30 14:49 ` Michal Hocko
2014-04-30 14:52 ` Rik van Riel
2014-04-30 14:41 ` [PATCH v3] " Rik van Riel
2014-04-30 19:00 ` Andrew Morton
2014-04-30 19:30 ` Rik van Riel
2014-04-30 19:35 ` Andrew Morton
2014-04-30 20:02 ` [PATCH v4] " Rik van Riel
2014-04-30 20:13 ` Andrew Morton
2014-04-30 20:32 ` Rik van Riel
2014-04-30 20:42 ` [PATCH v5] " Rik van Riel
2014-04-30 21:00 ` Andrew Morton
2014-04-30 21:21 ` Rik van Riel
2014-04-30 21:32 ` Andrew Morton
2014-05-02 9:16 ` Michal Hocko
2014-05-08 10:17 ` Masayoshi Mizuma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429151910.53f740ef@annuminas.surriel.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jweiner@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mpatlasov@parallels.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®