mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Bharath Ravi <rbharath@google.com>
Cc: Vaibhav Nagarnaik <vnagarnaik@google.com>,
	David Sharp <dhsharp@google.com>,
	Laurent Chavey <chavey@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing: Allow changing default ring buffer size for ftrace instances.
Date: Tue, 29 Apr 2014 18:19:29 -0400	[thread overview]
Message-ID: <20140429181929.01885052@gandalf.local.home> (raw)
In-Reply-To: <CAHN2JJ8WmyPPnVyJJxFg-OFJwrb9c6VuG5bUhkM82hjd3nwU4g@mail.gmail.com>

On Tue, 29 Apr 2014 15:09:15 -0700
Bharath Ravi <rbharath@google.com> wrote:

> We'd actually considered doing just that, in an initial version of the patch.
> At the time, we'd decided in favour of allowing the user more explicit
> control over the buffer size, rather than auto expanding it. (The
> discussion on that is here:
> https://lkml.org/lkml/2013/7/1/617)

Yeah, I remember my rational :-)

The thing is, I have been thinking more about it, and I'm now thinking
it would be fine. But reading that email again, I may have convinced
myself that it should have the option. Gah, I'm now arguing with myself!

> 
> We could go back to that though if you think that's okay, but I think
> your previous reasoning still makes sense: it's useful for the user to
> know if there will be an allocation failure before enabling tracing.

Grumble. I need to think about this a bit more. I'm stretching myself a
bit thin between different projects. I'll pull in you patches and play
with it a bit and then come back with a decision.

Thanks!

-- Steve

  reply	other threads:[~2014-04-29 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14 23:29 Bharath Ravi
2014-04-25 17:52 ` Steven Rostedt
2014-04-29 22:09   ` Bharath Ravi
2014-04-29 22:19     ` Steven Rostedt [this message]
2014-04-29 22:36 ` Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2014-01-23 19:37 Bharath Ravi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140429181929.01885052@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=chavey@google.com \
    --cc=dhsharp@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rbharath@google.com \
    --cc=vnagarnaik@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®