From: Fabian Frederick <fabf@skynet.be>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
hch <hch@infradead.org>, Viro <viro@zeniv.linux.org.uk>,
tytso <tytso@mit.edu>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH V3 1/2] FS: Add generic data flush to fsync
Date: Tue, 29 Apr 2014 18:25:30 +0200 [thread overview]
Message-ID: <20140429182530.177de75b86f4a074c2f536bf@skynet.be> (raw)
In-Reply-To: <20140429161907.GA29634@quack.suse.cz>
On Tue, 29 Apr 2014 18:19:07 +0200
Jan Kara <jack@suse.cz> wrote:
> On Mon 28-04-14 23:12:39, Fabian Frederick wrote:
> > This patch issues a flush in generic_file_fsync.
> > (Modern filesystems already do it)
> >
> > -Behaviour can be reversed using /sys/devices/.../cache_type
> > -Filesystems can also call __generic_file_fsync with bool flush false
> The patch looks good. You can add:
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
Just noticed I forgot to remove "with bool flush false" in patch description above
(-Filesystems can also call __generic_file_fsync "with bool flush false")
Tell me if I need to send the patch again.
Fabian
prev parent reply other threads:[~2014-04-29 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 21:12 Fabian Frederick
2014-04-29 16:19 ` Jan Kara
2014-04-29 16:25 ` Fabian Frederick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429182530.177de75b86f4a074c2f536bf@skynet.be \
--to=fabf@skynet.be \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®