mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <dyoung@redhat.com>
Cc: matt.fleming@intel.com, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] earlyprintk=efi,keep fix
Date: Wed, 30 Apr 2014 12:52:11 -0700	[thread overview]
Message-ID: <20140430125211.cb33039fc1248c953bcc13dc@linux-foundation.org> (raw)
In-Reply-To: <20140430021303.GA12316@darkstar.redhat.com>

On Wed, 30 Apr 2014 10:13:03 +0800 Dave Young <dyoung@redhat.com> wrote:

> 
> earlyprintk=efi,keep will cause kernel hangs while freeing initmem like below:
> [    2.826089] VFS: Mounted root (ext4 filesystem) readonly on device 254:2.
> [    2.846592] devtmpfs: mounted
> [    2.856974] Freeing unused kernel memory: 880K (ffffffff817d4000 - ffffffff818b0000)
> 
> It is caused by efi earlyprintk use __init function which will be freed later.
> Such as early_efi_write is marked as __init, also it will use early_ioremap
> which is init function as well.
> 
> To fix this issue, I added one early initcall efi_ioremap_fb which will map the whole
> efi fb for later use. OTOH, adding a wrapper function efi_ioremap which will call
> early_ioremap before ioremap is available.
> 
> With this patch applied efi boot ok with earlyprintk=efi,keep console=efi
> 

CONFIG_DEBUG_SECTION_MISMATCH should have detected this, but
CONFIG_DEBUG_SECTION_MISMATCH doesn't seem to work any more. 
scripts/Makefile.modpost appears to be trying to pass -S to modpost if
CONFIG_DEBUG_SECTION_MISMATCH, but I'm not seeing any warnings.  The
CONFIG_DEBUG_SECTION_MISMATCH Kconfig help is not useful.  What did we
do?

Shudder.  I'll assume Matt will handle this patch?

  reply	other threads:[~2014-04-30 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30  2:13 Dave Young
2014-04-30 19:52 ` Andrew Morton [this message]
2014-04-30 19:57   ` Matt Fleming
2014-05-01 10:12 ` Matt Fleming
2014-05-01 13:17   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140430125211.cb33039fc1248c953bcc13dc@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome