From: Mark Brown <broonie@kernel.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: Fix hung task timeout when initialization fails
Date: Wed, 30 Apr 2014 18:34:02 -0700 [thread overview]
Message-ID: <20140501013402.GL3245@sirena.org.uk> (raw)
In-Reply-To: <1398854171-5187-1-git-send-email-ricardo.ribalda@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Wed, Apr 30, 2014 at 12:36:11PM +0200, Ricardo Ribalda Delgado wrote:
> Since "786235eeba0e1e85e5cbbb9f97d1087ad03dfa21 kthread:
> make kthread_create() killable" kthread_run can be killed by the user,
> ie, by killing modprobe.
> - flush_kthread_worker(&master->kworker);
> - kthread_stop(master->kworker_task);
> + if (!IS_ERR(master->kworker_task)) {
> + flush_kthread_worker(&master->kworker);
> + kthread_stop(master->kworker_task);
> + }
How does this fix avoid racing with the task being killed? It will
improve things but it doesn't look like a full fix.
Please don't include entire backtraces in commit messages, they're
typically extremely long and don't really add anything - edited
highlights are fine but try to keep it to the point.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-01 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 10:36 Ricardo Ribalda Delgado
2014-05-01 1:34 ` Mark Brown [this message]
2014-05-01 5:53 ` Ricardo Ribalda Delgado
2014-05-01 14:11 ` Mark Brown
2014-05-01 14:33 ` Geert Uytterhoeven
2014-05-01 16:03 ` Mark Brown
2014-05-01 8:15 Ricardo Ribalda Delgado
2014-05-01 16:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501013402.GL3245@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®