From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 3/3] regulator: Add LTC3589 support
Date: Thu, 1 May 2014 11:07:38 -0700 [thread overview]
Message-ID: <20140501180738.GP3245@sirena.org.uk> (raw)
In-Reply-To: <1398789430-23897-3-git-send-email-p.zabel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Tue, Apr 29, 2014 at 06:37:10PM +0200, Philipp Zabel wrote:
> This patch adds support for the Linear Technology LTC3589, LTC3589-1,
> and LTC3589-2 8-output I2C voltage regulator ICs.
One small nit in addition to the vendor prefix thing:
> +static const int ltc3589_12_ldo4[] = {
> + 1200000, 1800000, 2500000, 3200000,
> +};
This could use regulator_map_voltage_ascend(), though for all practical
purposes the table is so small it makes no meaningful difference.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-01 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 16:37 [PATCH 1/3] of: Add vendor prefix for Linear Technology Corporation Philipp Zabel
2014-04-29 16:37 ` [PATCH 2/3] regulator: ltc3589: Add DT binding documentation Philipp Zabel
2014-05-01 18:04 ` Mark Brown
2014-05-05 7:17 ` Philipp Zabel
2014-04-29 16:37 ` [PATCH 3/3] regulator: Add LTC3589 support Philipp Zabel
2014-05-01 18:07 ` Mark Brown [this message]
2014-05-05 7:17 ` Philipp Zabel
2014-04-29 20:44 ` [PATCH 1/3] of: Add vendor prefix for Linear Technology Corporation Rob Herring
2014-04-30 8:26 ` Philipp Zabel
2014-05-01 4:05 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501180738.GP3245@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®