From: Mark Brown <broonie@kernel.org>
To: Zi Shen Lim <zlim@broadcom.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3] arm64: topology: add MPIDR-based detection
Date: Fri, 2 May 2014 13:04:33 -0700 [thread overview]
Message-ID: <20140502200433.GX3245@sirena.org.uk> (raw)
In-Reply-To: <1398814573-27389-1-git-send-email-zlim@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]
On Tue, Apr 29, 2014 at 04:36:13PM -0700, Zi Shen Lim wrote:
This looks good to me, modulo a couple of really tiny nitpicks.
Reviwed-by: Mark Brown <broonie@linaro.org>
I'm just doing some brief testing now, I'll repost my series with this
and Lorenzo's changes included shortly assuming no issues.
> if (cpuid_topo->cluster_id == -1) {
> - /*
> - * DT does not contain topology information for this cpu.
> - */
> + /* No topology information for this cpu ?! */
> pr_debug("CPU%u: No topology information configured\n", cpuid);
> return;
> }
Now that we have MPIDR support (well, will with this patch) this should
probably be raised to a pr_err() since we've got ourselves confused
somehow if it ever happens - we should always be able to get topology
from MPIDR. I'll tweak this when I repost.
> + pr_debug("CPU%u: cluster %d core %d thread %d mpidr %llx\n",
> + cpuid, cpuid_topo->cluster_id, cpuid_topo->core_id,
> + cpuid_topo->thread_id, mpidr);
I do wonder if we should print this either unconditionally or not at
all (rather than only if using MPIDR), I know Catalin and/or Lorenzo
weren't keen on noise but it is just at debug level and it's nice and
easy to refer to.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-05-02 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 23:36 Zi Shen Lim
2014-05-02 20:04 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502200433.GX3245@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
--cc=zlim@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®