From: Jeff Layton <jlayton@poochiereds.net>
To: David Rientjes <rientjes@google.com>
Cc: Marc Dietrich <marvin24@gmx.de>,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: nfs oom on 3.15
Date: Mon, 5 May 2014 07:08:12 -0400 [thread overview]
Message-ID: <20140505070812.470c66bd@tlielax.poochiereds.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1405050241180.11071@chino.kir.corp.google.com>
On Mon, 5 May 2014 02:42:35 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:
> On Mon, 5 May 2014, Marc Dietrich wrote:
>
> > Hi,
> >
> > this is spaming my log quite a bit.
> >
> > Any idea?
> >
>
> I think rpc_malloc() really wants to be __GFP_NOWARN so that the warnings
> are suppressed, doing order-1 allocations with GFP_NOWAIT is never
> guaranteed to succeed and will have difficulty if memory is fragmented.
Yes. We made a similar fix to xprt_alloc_slot a while back. The RPC
engine has a mechanism to handle retrying these allocations, so this
warning isn't particularly helpful.
--
Jeff Layton <jlayton@poochiereds.net>
next prev parent reply other threads:[~2014-05-05 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 8:15 Marc Dietrich
2014-05-05 9:42 ` David Rientjes
2014-05-05 11:08 ` Jeff Layton [this message]
2014-05-07 20:03 ` [patch] net, sunrpc: suppress allocation warning in rpc_malloc() David Rientjes
2014-05-28 23:29 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505070812.470c66bd@tlielax.poochiereds.net \
--to=jlayton@poochiereds.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®