From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Seunghun Lee <waydi1@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Improve missing blank line after declarations test
Date: Mon, 5 May 2014 15:42:38 -0700 [thread overview]
Message-ID: <20140505154238.a7a6606b474ca2f3a5b59471@linux-foundation.org> (raw)
In-Reply-To: <1399329343.27516.2.camel@joe-AO725>
On Mon, 05 May 2014 15:35:43 -0700 Joe Perches <joe@perches.com> wrote:
> > @@ -67,6 +68,7 @@ long vfs_truncate(struct path *path, lof
> > {
> > struct inode *inode;
> > long error;
> > + wobble();
> >
> > inode = path->dentry->d_inode;
>
> Patch content can be a bit odd when lines are
> both added and deleted so checkpatch bleats
> only when both lines are added.
>
> + int foo;
> + wibble();
>
> generates a complaint.
>
> int foo;
> + wibble_wobble();
>
> does not.
Oh, OK.
I have seen no instances of this warning since adding the patch. So I
guess it's safe to merge but perhaps insufficiently aggressive. Or
maybe people are being well-behaved.
Oh well, I'll keep an eye out.
prev parent reply other threads:[~2014-05-05 22:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 16:59 [PATCH] staging: android: fix missing a blank line after declarations Seunghun Lee
2014-04-29 17:32 ` Dan Carpenter
2014-05-03 23:43 ` Greg KH
2014-05-05 9:59 ` Dan Carpenter
2014-05-05 19:51 ` Joe Perches
2014-05-05 20:12 ` [PATCH] checkpatch: Improve missing blank line after declarations test Joe Perches
2014-05-05 22:15 ` Andrew Morton
2014-05-05 22:35 ` Joe Perches
2014-05-05 22:42 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505154238.a7a6606b474ca2f3a5b59471@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=waydi1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome